[bug-recutils] [PATCH] Fix distcheck: linking tests in torture/.

[Ralf Wildenhues]

---

Hi Jose,

* Jose E. Marchesi wrote on Sat, Jul 31, 2010 at 04:05:47PM CEST:
>     What is libcheck, where can I get it, and why is it needed for
>     librec?
> 
> `check' is a simple C unit testing framework that lives at
> http://check.sf.net.  I used libcheck because it is the testing
> infrastructure we use in GNU PDF as well.

Thanks.

> Do you know of any other suitable simple C testing framework?
> Preferably supporting fork-mode.

Not from first-hand experience.

>     Just wondering, my previous patches were untested, in the sense
>     that 'make check' didn't actually run any tests.
> 
> Well, actually 'make check' runs some tests in torture/rec-field/ and
> torture/rec-record/.  The test driver is in torture/runtests.c.
> 
> The test suite needs a lot of love, obviously: the current tests are
> more boilerplate than anything else.

Sure.  I've retested my patches with libcheck now, still works, with
this additional patch.

Cheers,
Ralf

 ChangeLog           |    6 ++++++
 torture/Makefile.am |    8 +++-----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index bc1d581..c61afc6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2010-07-31  Ralf Wildenhues  <address@hidden>
+
+       Fix distcheck: linking tests in torture/.
+       * torture/Makefile.am: Simplify.  Use relative path to librec.la
+       so dependencies are tracked correctly and distcheck works.
+
 2010-07-31  Jose E. Marchesi  <address@hidden>
 
        Make git to ignore some more generated files.
diff --git a/torture/Makefile.am b/torture/Makefile.am
index 3a1c97f..526f748 100644
--- a/torture/Makefile.am
+++ b/torture/Makefile.am
@@ -1,7 +1,7 @@
 # torture/ Makefile.am
 # GNU rec library
 
-# Copyright (C) 2009 Jose E. Marchesi
+# Copyright (C) 2009, 2010 Jose E. Marchesi
 
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -34,10 +34,8 @@ runtests_SOURCES = runtests.c \
                    $(REC_FIELD_TSUITE) \
                    $(REC_RECORD_TSUITE)
 
-runtests_CPPFLAGS = -I$(top_srcdir)/src
-runtests_LDFLAGS = -L$(top_srcdir)/src
-runtests_LDADD = $(CHECK_LIBS) \
-                 -lrec
+AM_CPPFLAGS = -I$(top_srcdir)/src
+runtests_LDADD = $(CHECK_LIBS) ../src/librec.la
 
 clean-local:
        -rm -f tests.log
-- 
1.7.2.rc3.47.g996ce