[REGRESSION] Incorrect mode in support/ in 8.2 (on HP-UX)

[Osipov, Michael (IN IT IN)]

Folks,

while trying to install 8.2 on HP-UX I have the following execution error:
> # gmake install
> /bin/sh ./support/mkinstalldirs /opt/ports/include \
>         /opt/ports/include/readline /opt/ports/lib/hpux32 \
>         /opt/ports/share/info /opt/ports/share/man/man3 
> /opt/ports/share/doc/readline \
>         /opt/ports/lib/hpux32/pkgconfig
> for f in readline.h chardefs.h keymaps.h history.h tilde.h rlstdc.h rlconf.h 
> rltypedefs.h; do \
>         ././support/install.sh -c -m 644 ./$f /opt/ports/include/readline ; \
> done
> /bin/sh[2]: ././support/install.sh: cannot execute
> /bin/sh[2]: ././support/install.sh: cannot execute
> /bin/sh[2]: ././support/install.sh: cannot execute
> /bin/sh[2]: ././support/install.sh: cannot execute
> /bin/sh[2]: ././support/install.sh: cannot execute
> /bin/sh[2]: ././support/install.sh: cannot execute
> /bin/sh[2]: ././support/install.sh: cannot execute
> /bin/sh[2]: ././support/install.sh: cannot execute
> gmake: *** [Makefile:234: install-headers] Error 126

The reason is here:
> osipovmi@deblndw011x:/tmp
> $ fetch https://ftp.gnu.org/gnu/readline/readline-8.2.tar.gz 
> https://ftp.gnu.org/gnu/readline/readline-8.1.2.tar.gz
> readline-8.2.tar.gz                                   2972 kB 1512 kBps    02s
> readline-8.1.2.tar.gz                                 2922 kB 1686 kBps    02s
> osipovmi@deblndw011x:/tmp
> $ tar -tzf readline-8.2.tar.gz | grep support/
> readline-8.2/support/
> readline-8.2/support/config.sub
> readline-8.2/support/mkinstalldirs
> readline-8.2/support/shlib-install
> readline-8.2/support/mkdist
> readline-8.2/support/mkdirs
> readline-8.2/support/install.sh
> readline-8.2/support/config.rpath
> readline-8.2/support/shobj-conf
> readline-8.2/support/config.guess
> readline-8.2/support/wcwidth.c
> osipovmi@deblndw011x:/tmp
> $ tar -tvzf readline-8.2.tar.gz | grep support/
> drwxr-xr-x  0 chet   staff       0 23 Sep.  2022 readline-8.2/support/
> -rw-r--r--  0 chet   staff   35406 11 Jan.  2022 readline-8.2/support/config.sub
> -rw-r--r--  0 chet   staff    1988  9 Dez.  2003 
> readline-8.2/support/mkinstalldirs
> -rw-r--r--  0 chet   staff    4404 13 Dez.  2019 
> readline-8.2/support/shlib-install
> -rw-r--r--  0 chet   staff    2970  8 Sep.  2022 readline-8.2/support/mkdist
> -rw-r--r--  0 chet   staff    1141 13 Aug.  2008 readline-8.2/support/mkdirs
> -rw-r--r--  0 chet   staff    5347 16 Apr.  2002 readline-8.2/support/install.sh
> -rw-r--r--  0 chet   staff   18574 22 Mai  2018 
> readline-8.2/support/config.rpath
> -rw-r--r--  0 chet   staff   13865  3 Dez.  2021 readline-8.2/support/shobj-conf
> -rw-r--r--  0 chet   staff   49482 11 Jan.  2022 
> readline-8.2/support/config.guess
> -rw-r--r--  0 chet   staff   13989 11 Aug.  2008 readline-8.2/support/wcwidth.c
> osipovmi@deblndw011x:/tmp
> $ tar -tvzf readline-8.1.2.tar.gz | grep support/
> drwxrwxr-x  0 chet   admin       0  4 Dez.  2020 readline-8.1.2/support/
> -rwxrwxr-x  0 chet   admin   18574 22 Mai  2018 
> readline-8.1.2/support/config.rpath
> -rw-rw-r--  0 chet   admin   13892 13 Dez.  2019 
> readline-8.1.2/support/shobj-conf
> -rwxr-xr-x  0 chet   admin    5347 16 Apr.  2002 
> readline-8.1.2/support/install.sh
> -rwxrwxr-x  0 chet   admin   49035 18 Nov.  2020 
> readline-8.1.2/support/config.guess
> -rwxrwxr-x  0 chet   admin    1141 13 Aug.  2008 readline-8.1.2/support/mkdirs
> -rwxrwxr-x  0 chet   admin    2661  9 März  2013 readline-8.1.2/support/mkdist
> -rwxrwxr-x  0 chet   admin   34212 18 Nov.  2020 
> readline-8.1.2/support/config.sub
> -rw-r--r--  0 chet   admin   13989 11 Aug.  2008 
> readline-8.1.2/support/wcwidth.c
> -r-xr-xr-x  0 chet   admin    1988  9 Dez.  2003 
> readline-8.1.2/support/mkinstalldirs
> -rwxr-xr-x  0 chet   admin    4404 13 Dez.  2019 
> readline-8.1.2/support/shlib-install

The execution bits are gone and sh isn't invoked in the Makefile.

My intermediate fix is just "chmod a+x ...", but that should be fixed in 
the source. The regression is here:
> diff --git a/support/install.sh b/support/install.sh
> old mode 100755
> new mode 100644
> diff --git a/support/mkdirs b/support/mkdirs
> old mode 100755
> new mode 100644
> diff --git a/support/mkdist b/support/mkdist
> old mode 100755
> new mode 100644

from f7a382fd09319b20ef4435b9b554183b605468c1

Regards,

Michael