Re: [Bug-readline] readline 8.0 in windows

[John Darrington]

As already mentioned, the w32 rename function behaves differently
to the posix one, especially when dealing with atomic moves.

However, if you use the replacement rename module provided with gnulib,
then it brings it very close to posix compliance.   In fact, if you look
at its w32 implementation it works very similar to that suggested below.

On Wed, Apr 03, 2019 at 06:39:14PM -0400, Chet Ramey wrote:
     On 4/3/19 4:54 PM, JohnD wrote:
     
     > For reference, Windoze does have its own 'rename' like function
     > 
https://docs.microsoft.com/en-us/windows/desktop/api/winbase/nf-winbase-movefileexa
     > 
     > So I was going to try adding something like:
     > static int
     > history_rename(const char *from, const char *to)
     > {
     > #if defined(_WIN32)
     >   if (!MoveFileEx(from, to, MOVEFILE_REPLACE_EXISTING)) {
     >     return -1;
     >   }
     >   return 0;
     > #else
     >   return rename(from, to);
     > #endif
     > }
     > 
     > And change the rename calls to history_rename