bug-readline
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-readline] [PATCH] Enable visibility annotations


From: Yury Gribov
Subject: Re: [Bug-readline] [PATCH] Enable visibility annotations
Date: Wed, 20 Apr 2016 09:22:54 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0

On 04/19/2016 06:32 PM, Yury Gribov wrote:
I realized that last email contained 5M attachment too late. Re-sending.

On 04/18/2016 02:18 PM, Pedro Alves wrote:
On 04/18/2016 11:57 AM, Yury Gribov wrote:
On 04/18/2016 01:19 PM, Pedro Alves wrote:

I ran this now and got:

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Symbols which may be used and are missing in new libreadline:
rl_complete_with_tilde_expansion
_rl_mark_modified_lines

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I wasn't expecting to ever see a "rl_" symbol here?  What was the
logic used to decide whether a symbol should be exported?

I only kept symbols which are present in public headers.

...

All three are declared in a file with descriptive name rlprivate.h.

Ah.  I wonder why they're named that way instead of using
the _rl_ prefix?  In any case, seems to me that whatever policy applied
to _rl_ symbols used by applications should be applied to these,
and there's at least one program using rl_complete_with_tilde_expansion.

FYI I have prepared a simple scanner for Debian packages (attached). It
takes all users of readline and checks whether they require any of
readline's symbols. On Ubuntu 14 in addition to already public symbols
this returns

completion_matches
ding
filename_completion_function
_rl_abort_internal
_rl_clean_up_for_exit
_rl_clear_screen
_rl_mark_modified_lines
_rl_move_vert
_rl_vis_botlin
sh_get_env_value
sh_get_home_dir

This does not include rl_complete_with_tilde_expansion because Ubuntu
lacks nmcli and also I wasn't able to apply to python3.2 and octave3.2
(those seem to not be downloadable today). Perhaps someone could
implement and run similar script for Fedora and yum?

There are other symbols here that look like should probably be public.
For example, history_offset is used by readline's examples:

   readline/src/examples/hist_purgecmd.c:44:extern int history_offset;
   readline/src/examples/hist_purgecmd.c:142:
history_offset--;     /* moving backwards in history list */
   readline/src/examples/hist_erasedups.c:41:extern int history_offset;
   readline/src/examples/hist_erasedups.c:114:
history_offset--;         /* moving backwards in history list */

so I'd assume that that's a public symbol and that those
examples no longer link after your patch?

Examples do link and run (most probably because they link static version
of readline).

That may well be.  It'd be good to make sure the readline and history
examples still work with a shared library version of readline.

In this particular case, I have no idea whether it's the examples that
should be using something else or whether it's the symbol that should be
declared public.  But this looks like something that should be addressed
one way or the other.  Not good to be giving out examples that
don't work, IMO.

I agree I'll see what they use and add relevant symbols to export tomorrow.

Here are the updated patches which include all symbols that are used in Ubuntu and readline examples. I've also verified that python3.2 and octave3.2 do not use non-public readline symbols.

With current patchset, it's still a decrease of readline interface from 654 to 428 symbols (35%).

-Y

>From 29765333906424efe6725500ec35d410a005bc78 Mon Sep 17 00:00:00 2001
From: Yury Gribov <address@hidden>
Date: Wed, 13 Apr 2016 16:51:23 +0300
Subject: [PATCH 1/3] Enable visibility.

---
 Makefile.in       |   3 +-
 compat.c          |  20 +-
 config.h.in       |   3 +
 configure.ac      |  18 ++
 history.h         |  94 ++++----
 keymaps.h         |  18 +-
 readline.h        | 698 +++++++++++++++++++++++++++---------------------------
 rlstdc.h          |   6 +
 shlib/Makefile.in |   3 +-
 tilde.h           |  20 +-
 10 files changed, 459 insertions(+), 424 deletions(-)

diff --git a/Makefile.in b/Makefile.in
index c0a0f1c..2dcd5bb 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -78,6 +78,7 @@ CTAGS = ctags -tw
 CFLAGS = @CFLAGS@
 LOCAL_CFLAGS = @LOCAL_CFLAGS@ -DRL_LIBRARY_VERSION='"$(RL_LIBRARY_VERSION)"'
 CPPFLAGS = @CPPFLAGS@
+CFLAGS_VISIBILITY = @CFLAGS_VISIBILITY@
 
 DEFS = @DEFS@ @CROSS_COMPILE@
 LOCAL_DEFS = @LOCAL_DEFS@
@@ -88,7 +89,7 @@ TERMCAP_LIB = @TERMCAP_LIB@
 INCLUDES = -I. -I$(srcdir)
 
 XCCFLAGS = $(DEFS) $(LOCAL_DEFS) $(CPPFLAGS) $(INCLUDES)
-CCFLAGS = $(XCCFLAGS) $(LOCAL_CFLAGS) $(CFLAGS)
+CCFLAGS = $(XCCFLAGS) $(LOCAL_CFLAGS) $(CFLAGS) $(CFLAGS_VISIBILITY)
 
 # could add -Werror here
 GCC_LINT_FLAGS = -ansi -Wall -Wshadow -Wpointer-arith -Wcast-qual \
diff --git a/compat.c b/compat.c
index 2af5120..2710e57 100644
--- a/compat.c
+++ b/compat.c
@@ -45,50 +45,50 @@ extern char *rl_filename_completion_function PARAMS((const 
char *, int));
 
 /* Provide backwards-compatible entry points for old function names. */
 
-void
+READLINE_EXPORT void
 free_undo_list ()
 {
   rl_free_undo_list ();
 }
 
-int
+READLINE_EXPORT int
 maybe_replace_line ()
 {
   return rl_maybe_replace_line ();
 }
 
-int
+READLINE_EXPORT int
 maybe_save_line ()
 {
   return rl_maybe_save_line ();
 }
 
-int
+READLINE_EXPORT int
 maybe_unsave_line ()
 {
   return rl_maybe_unsave_line ();
 }
 
-int
+READLINE_EXPORT int
 ding ()
 {
   return rl_ding ();
 }
 
-int
+READLINE_EXPORT int
 crlf ()
 {
   return rl_crlf ();
 }
 
-int
+READLINE_EXPORT int
 alphabetic (c)
      int c;
 {
   return rl_alphabetic (c);
 }
 
-char **
+READLINE_EXPORT char **
 completion_matches (s, f)
      const char *s;
      rl_compentry_func_t *f;
@@ -96,7 +96,7 @@ completion_matches (s, f)
   return rl_completion_matches (s, f);
 }
 
-char *
+READLINE_EXPORT char *
 username_completion_function (s, i)
      const char *s;
      int i;
@@ -104,7 +104,7 @@ username_completion_function (s, i)
   return rl_username_completion_function (s, i);
 }
 
-char *
+READLINE_EXPORT char *
 filename_completion_function (s, i)
      const char *s;
      int i;
diff --git a/config.h.in b/config.h.in
index a67e43e..e2b0e7e 100644
--- a/config.h.in
+++ b/config.h.in
@@ -268,4 +268,7 @@
 #  define TERMIOS_MISSING
 #endif
 
+/* Define if compiler supports visibility. */
+#undef HAVE_VISIBILITY
+
 /* VARARGS defines moved to rlstdc.h */
diff --git a/configure.ac b/configure.ac
index cea8f91..2f33b8b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -209,6 +209,24 @@ case "$host_os" in
 isc*)  LOCAL_CFLAGS=-Disc386 ;;
 esac
 
+save_CFLAGS="$CFLAGS"
+CFLAGS="$CFLAGS -fvisibility=hidden"
+CFLAGS_VISIBILITY=
+HAVE_VISIBILITY=0
+AC_COMPILE_IFELSE(
+  [AC_LANG_SOURCE([[
+    #if defined(__CYGWIN__) || defined(__MINGW32__)
+    #error No visibility support
+    #endif
+    extern __attribute__((__visibility__("default"))) int x;
+  ]])],
+  [CFLAGS_VISIBILITY=-fvisibility=hidden
+   AC_DEFINE(HAVE_VISIBILITY)],
+  []
+)
+CFLAGS="$save_CFLAGS"
+AC_SUBST([CFLAGS_VISIBILITY])
+
 # shared library configuration section
 #
 # Shared object configuration section.  These values are generated by
diff --git a/history.h b/history.h
index c8af47e..607d961 100644
--- a/history.h
+++ b/history.h
@@ -68,93 +68,93 @@ typedef struct _hist_state {
 
 /* Begin a session in which the history functions might be used.  This
    just initializes the interactive variables. */
-extern void using_history PARAMS((void));
+READLINE_EXPORT void using_history PARAMS((void));
 
 /* Return the current HISTORY_STATE of the history. */
-extern HISTORY_STATE *history_get_history_state PARAMS((void));
+READLINE_EXPORT HISTORY_STATE *history_get_history_state PARAMS((void));
 
 /* Set the state of the current history array to STATE. */
-extern void history_set_history_state PARAMS((HISTORY_STATE *));
+READLINE_EXPORT void history_set_history_state PARAMS((HISTORY_STATE *));
 
 /* Manage the history list. */
 
 /* Place STRING at the end of the history list.
    The associated data field (if any) is set to NULL. */
-extern void add_history PARAMS((const char *));
+READLINE_EXPORT void add_history PARAMS((const char *));
 
 /* Change the timestamp associated with the most recent history entry to
    STRING. */
-extern void add_history_time PARAMS((const char *));
+READLINE_EXPORT void add_history_time PARAMS((const char *));
 
 /* A reasonably useless function, only here for completeness.  WHICH
    is the magic number that tells us which element to delete.  The
    elements are numbered from 0. */
-extern HIST_ENTRY *remove_history PARAMS((int));
+READLINE_EXPORT HIST_ENTRY *remove_history PARAMS((int));
 
 /* Free the history entry H and return any application-specific data
    associated with it. */
-extern histdata_t free_history_entry PARAMS((HIST_ENTRY *));
+READLINE_EXPORT histdata_t free_history_entry PARAMS((HIST_ENTRY *));
 
 /* Make the history entry at WHICH have LINE and DATA.  This returns
    the old entry so you can dispose of the data.  In the case of an
    invalid WHICH, a NULL pointer is returned. */
-extern HIST_ENTRY *replace_history_entry PARAMS((int, const char *, 
histdata_t));
+READLINE_EXPORT HIST_ENTRY *replace_history_entry PARAMS((int, const char *, 
histdata_t));
 
 /* Clear the history list and start over. */
-extern void clear_history PARAMS((void));
+READLINE_EXPORT void clear_history PARAMS((void));
 
 /* Stifle the history list, remembering only MAX number of entries. */
-extern void stifle_history PARAMS((int));
+READLINE_EXPORT void stifle_history PARAMS((int));
 
 /* Stop stifling the history.  This returns the previous amount the
    history was stifled by.  The value is positive if the history was
    stifled, negative if it wasn't. */
-extern int unstifle_history PARAMS((void));
+READLINE_EXPORT int unstifle_history PARAMS((void));
 
 /* Return 1 if the history is stifled, 0 if it is not. */
-extern int history_is_stifled PARAMS((void));
+READLINE_EXPORT int history_is_stifled PARAMS((void));
 
 /* Information about the history list. */
 
 /* Return a NULL terminated array of HIST_ENTRY which is the current input
    history.  Element 0 of this list is the beginning of time.  If there
    is no history, return NULL. */
-extern HIST_ENTRY **history_list PARAMS((void));
+READLINE_EXPORT HIST_ENTRY **history_list PARAMS((void));
 
 /* Returns the number which says what history element we are now
    looking at.  */
-extern int where_history PARAMS((void));
+READLINE_EXPORT int where_history PARAMS((void));
   
 /* Return the history entry at the current position, as determined by
    history_offset.  If there is no entry there, return a NULL pointer. */
-extern HIST_ENTRY *current_history PARAMS((void));
+READLINE_EXPORT HIST_ENTRY *current_history PARAMS((void));
 
 /* Return the history entry which is logically at OFFSET in the history
    array.  OFFSET is relative to history_base. */
-extern HIST_ENTRY *history_get PARAMS((int));
+READLINE_EXPORT HIST_ENTRY *history_get PARAMS((int));
 
 /* Return the timestamp associated with the HIST_ENTRY * passed as an
    argument */
-extern time_t history_get_time PARAMS((HIST_ENTRY *));
+READLINE_EXPORT time_t history_get_time PARAMS((HIST_ENTRY *));
 
 /* Return the number of bytes that the primary history entries are using.
    This just adds up the lengths of the_history->lines. */
-extern int history_total_bytes PARAMS((void));
+READLINE_EXPORT int history_total_bytes PARAMS((void));
 
 /* Moving around the history list. */
 
 /* Set the position in the history list to POS. */
-extern int history_set_pos PARAMS((int));
+READLINE_EXPORT int history_set_pos PARAMS((int));
 
 /* Back up history_offset to the previous history entry, and return
    a pointer to that entry.  If there is no previous entry, return
    a NULL pointer. */
-extern HIST_ENTRY *previous_history PARAMS((void));
+READLINE_EXPORT HIST_ENTRY *previous_history PARAMS((void));
 
 /* Move history_offset forward to the next item in the input_history,
    and return the a pointer to that entry.  If there is no next entry,
    return a NULL pointer. */
-extern HIST_ENTRY *next_history PARAMS((void));
+READLINE_EXPORT HIST_ENTRY *next_history PARAMS((void));
 
 /* Searching the history list. */
 
@@ -164,45 +164,45 @@ extern HIST_ENTRY *next_history PARAMS((void));
    current_history () is the history entry, and the value of this function
    is the offset in the line of that history entry that the string was
    found in.  Otherwise, nothing is changed, and a -1 is returned. */
-extern int history_search PARAMS((const char *, int));
+READLINE_EXPORT int history_search PARAMS((const char *, int));
 
 /* Search the history for STRING, starting at history_offset.
    The search is anchored: matching lines must begin with string.
    DIRECTION is as in history_search(). */
-extern int history_search_prefix PARAMS((const char *, int));
+READLINE_EXPORT int history_search_prefix PARAMS((const char *, int));
 
 /* Search for STRING in the history list, starting at POS, an
    absolute index into the list.  DIR, if negative, says to search
    backwards from POS, else forwards.
    Returns the absolute index of the history element where STRING
    was found, or -1 otherwise. */
-extern int history_search_pos PARAMS((const char *, int, int));
+READLINE_EXPORT int history_search_pos PARAMS((const char *, int, int));
 
 /* Managing the history file. */
 
 /* Add the contents of FILENAME to the history list, a line at a time.
    If FILENAME is NULL, then read from ~/.history.  Returns 0 if
    successful, or errno if not. */
-extern int read_history PARAMS((const char *));
+READLINE_EXPORT int read_history PARAMS((const char *));
 
 /* Read a range of lines from FILENAME, adding them to the history list.
    Start reading at the FROM'th line and end at the TO'th.  If FROM
    is zero, start at the beginning.  If TO is less than FROM, read
    until the end of the file.  If FILENAME is NULL, then read from
    ~/.history.  Returns 0 if successful, or errno if not. */
-extern int read_history_range PARAMS((const char *, int, int));
+READLINE_EXPORT int read_history_range PARAMS((const char *, int, int));
 
 /* Write the current history to FILENAME.  If FILENAME is NULL,
    then write the history list to ~/.history.  Values returned
    are as in read_history ().  */
-extern int write_history PARAMS((const char *));
+READLINE_EXPORT int write_history PARAMS((const char *));
 
 /* Append NELEMENT entries to FILENAME.  The entries appended are from
    the end of the list minus NELEMENTs up to the end of the list. */
-extern int append_history PARAMS((int, const char *));
+READLINE_EXPORT int append_history PARAMS((int, const char *));
 
 /* Truncate the history file, leaving only the last NLINES lines. */
-extern int history_truncate_file PARAMS((const char *, int));
+READLINE_EXPORT int history_truncate_file PARAMS((const char *, int));
 
 /* History expansion. */
 
@@ -218,12 +218,12 @@ extern int history_truncate_file PARAMS((const char *, 
int));
 
   If an error occurred in expansion, then OUTPUT contains a descriptive
   error message. */
-extern int history_expand PARAMS((char *, char **));
+READLINE_EXPORT int history_expand PARAMS((char *, char **));
 
 /* Extract a string segment consisting of the FIRST through LAST
    arguments present in STRING.  Arguments are broken up as in
    the shell. */
-extern char *history_arg_extract PARAMS((int, int, const char *));
+READLINE_EXPORT char *history_arg_extract PARAMS((int, int, const char *));
 
 /* Return the text of the history event beginning at the current
    offset into STRING.  Pass STRING with *INDEX equal to the
@@ -231,33 +231,33 @@ extern char *history_arg_extract PARAMS((int, int, const 
char *));
    DELIMITING_QUOTE is a character that is allowed to end the string
    specification for what to search for in addition to the normal
    characters `:', ` ', `\t', `\n', and sometimes `?'. */
-extern char *get_history_event PARAMS((const char *, int *, int));
+READLINE_EXPORT char *get_history_event PARAMS((const char *, int *, int));
 
 /* Return an array of tokens, much as the shell might.  The tokens are
    parsed out of STRING. */
-extern char **history_tokenize PARAMS((const char *));
+READLINE_EXPORT char **history_tokenize PARAMS((const char *));
 
 /* Exported history variables. */
-extern int history_base;
-extern int history_length;
-extern int history_max_entries;
-extern char history_expansion_char;
-extern char history_subst_char;
-extern char *history_word_delimiters;
-extern char history_comment_char;
-extern char *history_no_expand_chars;
-extern char *history_search_delimiter_chars;
-extern int history_quotes_inhibit_expansion;
-
-extern int history_write_timestamps;
+READLINE_EXPORT int history_base;
+READLINE_EXPORT int history_length;
+READLINE_EXPORT int history_max_entries;
+READLINE_EXPORT char history_expansion_char;
+READLINE_EXPORT char history_subst_char;
+READLINE_EXPORT char *history_word_delimiters;
+READLINE_EXPORT char history_comment_char;
+READLINE_EXPORT char *history_no_expand_chars;
+READLINE_EXPORT char *history_search_delimiter_chars;
+READLINE_EXPORT int history_quotes_inhibit_expansion;
+
+READLINE_EXPORT int history_write_timestamps;
 
 /* Backwards compatibility */
-extern int max_input_history;
+READLINE_EXPORT int max_input_history;
 
 /* If set, this function is called to decide whether or not a particular
    history expansion should be treated as a special case for the calling
    application and not expanded. */
-extern rl_linebuf_func_t *history_inhibit_expansion_function;
+READLINE_EXPORT rl_linebuf_func_t *history_inhibit_expansion_function;
 
 #ifdef __cplusplus
 }
diff --git a/keymaps.h b/keymaps.h
index af8d5d9..c3441b7 100644
--- a/keymaps.h
+++ b/keymaps.h
@@ -60,35 +60,35 @@ typedef KEYMAP_ENTRY *Keymap;
 #define ISKMAP 1
 #define ISMACR 2
 
-extern KEYMAP_ENTRY_ARRAY emacs_standard_keymap, emacs_meta_keymap, 
emacs_ctlx_keymap;
-extern KEYMAP_ENTRY_ARRAY vi_insertion_keymap, vi_movement_keymap;
+READLINE_EXPORT KEYMAP_ENTRY_ARRAY emacs_standard_keymap, emacs_meta_keymap, 
emacs_ctlx_keymap;
+READLINE_EXPORT KEYMAP_ENTRY_ARRAY vi_insertion_keymap, vi_movement_keymap;
 
 /* Return a new, empty keymap.
    Free it with free() when you are done. */
-extern Keymap rl_make_bare_keymap PARAMS((void));
+READLINE_EXPORT Keymap rl_make_bare_keymap PARAMS((void));
 
 /* Return a new keymap which is a copy of MAP. */
-extern Keymap rl_copy_keymap PARAMS((Keymap));
+READLINE_EXPORT Keymap rl_copy_keymap PARAMS((Keymap));
 
 /* Return a new keymap with the printing characters bound to rl_insert,
    the lowercase Meta characters bound to run their equivalents, and
    the Meta digits bound to produce numeric arguments. */
-extern Keymap rl_make_keymap PARAMS((void));
+READLINE_EXPORT Keymap rl_make_keymap PARAMS((void));
 
 /* Free the storage associated with a keymap. */
-extern void rl_discard_keymap PARAMS((Keymap));
+READLINE_EXPORT void rl_discard_keymap PARAMS((Keymap));
 
 /* These functions actually appear in bind.c */
 
 /* Return the keymap corresponding to a given name.  Names look like
    `emacs' or `emacs-meta' or `vi-insert'.  */
-extern Keymap rl_get_keymap_by_name PARAMS((const char *));
+READLINE_EXPORT Keymap rl_get_keymap_by_name PARAMS((const char *));
 
 /* Return the current keymap. */
-extern Keymap rl_get_keymap PARAMS((void));
+READLINE_EXPORT Keymap rl_get_keymap PARAMS((void));
 
 /* Set the current keymap to MAP. */
-extern void rl_set_keymap PARAMS((Keymap));
+READLINE_EXPORT void rl_set_keymap PARAMS((Keymap));
 
 #ifdef __cplusplus
 }
diff --git a/readline.h b/readline.h
index 08dcd2b..229bc36 100644
--- a/readline.h
+++ b/readline.h
@@ -62,7 +62,7 @@ typedef struct undo_list {
 } UNDO_LIST;
 
 /* The current undo list for RL_LINE_BUFFER. */
-extern UNDO_LIST *rl_undo_list;
+READLINE_EXPORT UNDO_LIST *rl_undo_list;
 
 /* The data structure for mapping textual names to code addresses. */
 typedef struct _funmap {
@@ -70,7 +70,7 @@ typedef struct _funmap {
   rl_command_func_t *function;
 } FUNMAP;
 
-extern FUNMAP **funmap;
+READLINE_EXPORT FUNMAP **funmap;
 
 /* **************************************************************** */
 /*                                                                 */
@@ -79,202 +79,202 @@ extern FUNMAP **funmap;
 /* **************************************************************** */
 
 /* Bindable commands for numeric arguments. */
-extern int rl_digit_argument PARAMS((int, int));
-extern int rl_universal_argument PARAMS((int, int));
+READLINE_EXPORT int rl_digit_argument PARAMS((int, int));
+READLINE_EXPORT int rl_universal_argument PARAMS((int, int));
 
 /* Bindable commands for moving the cursor. */
-extern int rl_forward_byte PARAMS((int, int));
-extern int rl_forward_char PARAMS((int, int));
-extern int rl_forward PARAMS((int, int));
-extern int rl_backward_byte PARAMS((int, int));
-extern int rl_backward_char PARAMS((int, int));
-extern int rl_backward PARAMS((int, int));
-extern int rl_beg_of_line PARAMS((int, int));
-extern int rl_end_of_line PARAMS((int, int));
-extern int rl_forward_word PARAMS((int, int));
-extern int rl_backward_word PARAMS((int, int));
-extern int rl_refresh_line PARAMS((int, int));
-extern int rl_clear_screen PARAMS((int, int));
-extern int rl_skip_csi_sequence PARAMS((int, int));
-extern int rl_arrow_keys PARAMS((int, int));
+READLINE_EXPORT int rl_forward_byte PARAMS((int, int));
+READLINE_EXPORT int rl_forward_char PARAMS((int, int));
+READLINE_EXPORT int rl_forward PARAMS((int, int));
+READLINE_EXPORT int rl_backward_byte PARAMS((int, int));
+READLINE_EXPORT int rl_backward_char PARAMS((int, int));
+READLINE_EXPORT int rl_backward PARAMS((int, int));
+READLINE_EXPORT int rl_beg_of_line PARAMS((int, int));
+READLINE_EXPORT int rl_end_of_line PARAMS((int, int));
+READLINE_EXPORT int rl_forward_word PARAMS((int, int));
+READLINE_EXPORT int rl_backward_word PARAMS((int, int));
+READLINE_EXPORT int rl_refresh_line PARAMS((int, int));
+READLINE_EXPORT int rl_clear_screen PARAMS((int, int));
+READLINE_EXPORT int rl_skip_csi_sequence PARAMS((int, int));
+READLINE_EXPORT int rl_arrow_keys PARAMS((int, int));
 
 /* Bindable commands for inserting and deleting text. */
-extern int rl_insert PARAMS((int, int));
-extern int rl_quoted_insert PARAMS((int, int));
-extern int rl_tab_insert PARAMS((int, int));
-extern int rl_newline PARAMS((int, int));
-extern int rl_do_lowercase_version PARAMS((int, int));
-extern int rl_rubout PARAMS((int, int));
-extern int rl_delete PARAMS((int, int));
-extern int rl_rubout_or_delete PARAMS((int, int));
-extern int rl_delete_horizontal_space PARAMS((int, int));
-extern int rl_delete_or_show_completions PARAMS((int, int));
-extern int rl_insert_comment PARAMS((int, int));
+READLINE_EXPORT int rl_insert PARAMS((int, int));
+READLINE_EXPORT int rl_quoted_insert PARAMS((int, int));
+READLINE_EXPORT int rl_tab_insert PARAMS((int, int));
+READLINE_EXPORT int rl_newline PARAMS((int, int));
+READLINE_EXPORT int rl_do_lowercase_version PARAMS((int, int));
+READLINE_EXPORT int rl_rubout PARAMS((int, int));
+READLINE_EXPORT int rl_delete PARAMS((int, int));
+READLINE_EXPORT int rl_rubout_or_delete PARAMS((int, int));
+READLINE_EXPORT int rl_delete_horizontal_space PARAMS((int, int));
+READLINE_EXPORT int rl_delete_or_show_completions PARAMS((int, int));
+READLINE_EXPORT int rl_insert_comment PARAMS((int, int));
 
 /* Bindable commands for changing case. */
-extern int rl_upcase_word PARAMS((int, int));
-extern int rl_downcase_word PARAMS((int, int));
-extern int rl_capitalize_word PARAMS((int, int));
+READLINE_EXPORT int rl_upcase_word PARAMS((int, int));
+READLINE_EXPORT int rl_downcase_word PARAMS((int, int));
+READLINE_EXPORT int rl_capitalize_word PARAMS((int, int));
 
 /* Bindable commands for transposing characters and words. */
-extern int rl_transpose_words PARAMS((int, int));
-extern int rl_transpose_chars PARAMS((int, int));
+READLINE_EXPORT int rl_transpose_words PARAMS((int, int));
+READLINE_EXPORT int rl_transpose_chars PARAMS((int, int));
 
 /* Bindable commands for searching within a line. */
-extern int rl_char_search PARAMS((int, int));
-extern int rl_backward_char_search PARAMS((int, int));
+READLINE_EXPORT int rl_char_search PARAMS((int, int));
+READLINE_EXPORT int rl_backward_char_search PARAMS((int, int));
 
 /* Bindable commands for readline's interface to the command history. */
-extern int rl_beginning_of_history PARAMS((int, int));
-extern int rl_end_of_history PARAMS((int, int));
-extern int rl_get_next_history PARAMS((int, int));
-extern int rl_get_previous_history PARAMS((int, int));
+READLINE_EXPORT int rl_beginning_of_history PARAMS((int, int));
+READLINE_EXPORT int rl_end_of_history PARAMS((int, int));
+READLINE_EXPORT int rl_get_next_history PARAMS((int, int));
+READLINE_EXPORT int rl_get_previous_history PARAMS((int, int));
 
 /* Bindable commands for managing the mark and region. */
-extern int rl_set_mark PARAMS((int, int));
-extern int rl_exchange_point_and_mark PARAMS((int, int));
+READLINE_EXPORT int rl_set_mark PARAMS((int, int));
+READLINE_EXPORT int rl_exchange_point_and_mark PARAMS((int, int));
 
 /* Bindable commands to set the editing mode (emacs or vi). */
-extern int rl_vi_editing_mode PARAMS((int, int));
-extern int rl_emacs_editing_mode PARAMS((int, int));
+READLINE_EXPORT int rl_vi_editing_mode PARAMS((int, int));
+READLINE_EXPORT int rl_emacs_editing_mode PARAMS((int, int));
 
 /* Bindable commands to change the insert mode (insert or overwrite) */
-extern int rl_overwrite_mode PARAMS((int, int));
+READLINE_EXPORT int rl_overwrite_mode PARAMS((int, int));
 
 /* Bindable commands for managing key bindings. */
-extern int rl_re_read_init_file PARAMS((int, int));
-extern int rl_dump_functions PARAMS((int, int));
-extern int rl_dump_macros PARAMS((int, int));
-extern int rl_dump_variables PARAMS((int, int));
+READLINE_EXPORT int rl_re_read_init_file PARAMS((int, int));
+READLINE_EXPORT int rl_dump_functions PARAMS((int, int));
+READLINE_EXPORT int rl_dump_macros PARAMS((int, int));
+READLINE_EXPORT int rl_dump_variables PARAMS((int, int));
 
 /* Bindable commands for word completion. */
-extern int rl_complete PARAMS((int, int));
-extern int rl_possible_completions PARAMS((int, int));
-extern int rl_insert_completions PARAMS((int, int));
-extern int rl_old_menu_complete PARAMS((int, int));
-extern int rl_menu_complete PARAMS((int, int));
-extern int rl_backward_menu_complete PARAMS((int, int));
+READLINE_EXPORT int rl_complete PARAMS((int, int));
+READLINE_EXPORT int rl_possible_completions PARAMS((int, int));
+READLINE_EXPORT int rl_insert_completions PARAMS((int, int));
+READLINE_EXPORT int rl_old_menu_complete PARAMS((int, int));
+READLINE_EXPORT int rl_menu_complete PARAMS((int, int));
+READLINE_EXPORT int rl_backward_menu_complete PARAMS((int, int));
 
 /* Bindable commands for killing and yanking text, and managing the kill ring. 
*/
-extern int rl_kill_word PARAMS((int, int));
-extern int rl_backward_kill_word PARAMS((int, int));
-extern int rl_kill_line PARAMS((int, int));
-extern int rl_backward_kill_line PARAMS((int, int));
-extern int rl_kill_full_line PARAMS((int, int));
-extern int rl_unix_word_rubout PARAMS((int, int));
-extern int rl_unix_filename_rubout PARAMS((int, int));
-extern int rl_unix_line_discard PARAMS((int, int));
-extern int rl_copy_region_to_kill PARAMS((int, int));
-extern int rl_kill_region PARAMS((int, int));
-extern int rl_copy_forward_word PARAMS((int, int));
-extern int rl_copy_backward_word PARAMS((int, int));
-extern int rl_yank PARAMS((int, int));
-extern int rl_yank_pop PARAMS((int, int));
-extern int rl_yank_nth_arg PARAMS((int, int));
-extern int rl_yank_last_arg PARAMS((int, int));
+READLINE_EXPORT int rl_kill_word PARAMS((int, int));
+READLINE_EXPORT int rl_backward_kill_word PARAMS((int, int));
+READLINE_EXPORT int rl_kill_line PARAMS((int, int));
+READLINE_EXPORT int rl_backward_kill_line PARAMS((int, int));
+READLINE_EXPORT int rl_kill_full_line PARAMS((int, int));
+READLINE_EXPORT int rl_unix_word_rubout PARAMS((int, int));
+READLINE_EXPORT int rl_unix_filename_rubout PARAMS((int, int));
+READLINE_EXPORT int rl_unix_line_discard PARAMS((int, int));
+READLINE_EXPORT int rl_copy_region_to_kill PARAMS((int, int));
+READLINE_EXPORT int rl_kill_region PARAMS((int, int));
+READLINE_EXPORT int rl_copy_forward_word PARAMS((int, int));
+READLINE_EXPORT int rl_copy_backward_word PARAMS((int, int));
+READLINE_EXPORT int rl_yank PARAMS((int, int));
+READLINE_EXPORT int rl_yank_pop PARAMS((int, int));
+READLINE_EXPORT int rl_yank_nth_arg PARAMS((int, int));
+READLINE_EXPORT int rl_yank_last_arg PARAMS((int, int));
 /* Not available unless __CYGWIN__ is defined. */
 #ifdef __CYGWIN__
-extern int rl_paste_from_clipboard PARAMS((int, int));
+READLINE_EXPORT int rl_paste_from_clipboard PARAMS((int, int));
 #endif
 
 /* Bindable commands for incremental searching. */
-extern int rl_reverse_search_history PARAMS((int, int));
-extern int rl_forward_search_history PARAMS((int, int));
+READLINE_EXPORT int rl_reverse_search_history PARAMS((int, int));
+READLINE_EXPORT int rl_forward_search_history PARAMS((int, int));
 
 /* Bindable keyboard macro commands. */
-extern int rl_start_kbd_macro PARAMS((int, int));
-extern int rl_end_kbd_macro PARAMS((int, int));
-extern int rl_call_last_kbd_macro PARAMS((int, int));
-extern int rl_print_last_kbd_macro PARAMS((int, int));
+READLINE_EXPORT int rl_start_kbd_macro PARAMS((int, int));
+READLINE_EXPORT int rl_end_kbd_macro PARAMS((int, int));
+READLINE_EXPORT int rl_call_last_kbd_macro PARAMS((int, int));
+READLINE_EXPORT int rl_print_last_kbd_macro PARAMS((int, int));
 
 /* Bindable undo commands. */
-extern int rl_revert_line PARAMS((int, int));
-extern int rl_undo_command PARAMS((int, int));
+READLINE_EXPORT int rl_revert_line PARAMS((int, int));
+READLINE_EXPORT int rl_undo_command PARAMS((int, int));
 
 /* Bindable tilde expansion commands. */
-extern int rl_tilde_expand PARAMS((int, int));
+READLINE_EXPORT int rl_tilde_expand PARAMS((int, int));
 
 /* Bindable terminal control commands. */
-extern int rl_restart_output PARAMS((int, int));
-extern int rl_stop_output PARAMS((int, int));
+READLINE_EXPORT int rl_restart_output PARAMS((int, int));
+READLINE_EXPORT int rl_stop_output PARAMS((int, int));
 
 /* Miscellaneous bindable commands. */
-extern int rl_abort PARAMS((int, int));
-extern int rl_tty_status PARAMS((int, int));
+READLINE_EXPORT int rl_abort PARAMS((int, int));
+READLINE_EXPORT int rl_tty_status PARAMS((int, int));
 
 /* Bindable commands for incremental and non-incremental history searching. */
-extern int rl_history_search_forward PARAMS((int, int));
-extern int rl_history_search_backward PARAMS((int, int));
-extern int rl_history_substr_search_forward PARAMS((int, int));
-extern int rl_history_substr_search_backward PARAMS((int, int));
-extern int rl_noninc_forward_search PARAMS((int, int));
-extern int rl_noninc_reverse_search PARAMS((int, int));
-extern int rl_noninc_forward_search_again PARAMS((int, int));
-extern int rl_noninc_reverse_search_again PARAMS((int, int));
+READLINE_EXPORT int rl_history_search_forward PARAMS((int, int));
+READLINE_EXPORT int rl_history_search_backward PARAMS((int, int));
+READLINE_EXPORT int rl_history_substr_search_forward PARAMS((int, int));
+READLINE_EXPORT int rl_history_substr_search_backward PARAMS((int, int));
+READLINE_EXPORT int rl_noninc_forward_search PARAMS((int, int));
+READLINE_EXPORT int rl_noninc_reverse_search PARAMS((int, int));
+READLINE_EXPORT int rl_noninc_forward_search_again PARAMS((int, int));
+READLINE_EXPORT int rl_noninc_reverse_search_again PARAMS((int, int));
 
 /* Bindable command used when inserting a matching close character. */
-extern int rl_insert_close PARAMS((int, int));
+READLINE_EXPORT int rl_insert_close PARAMS((int, int));
 
 /* Not available unless READLINE_CALLBACKS is defined. */
-extern void rl_callback_handler_install PARAMS((const char *, rl_vcpfunc_t *));
-extern void rl_callback_read_char PARAMS((void));
-extern void rl_callback_handler_remove PARAMS((void));
+READLINE_EXPORT void rl_callback_handler_install PARAMS((const char *, 
rl_vcpfunc_t *));
+READLINE_EXPORT void rl_callback_read_char PARAMS((void));
+READLINE_EXPORT void rl_callback_handler_remove PARAMS((void));
 
 /* Things for vi mode. Not available unless readline is compiled -DVI_MODE. */
 /* VI-mode bindable commands. */
-extern int rl_vi_redo PARAMS((int, int));
-extern int rl_vi_undo PARAMS((int, int));
-extern int rl_vi_yank_arg PARAMS((int, int));
-extern int rl_vi_fetch_history PARAMS((int, int));
-extern int rl_vi_search_again PARAMS((int, int));
-extern int rl_vi_search PARAMS((int, int));
-extern int rl_vi_complete PARAMS((int, int));
-extern int rl_vi_tilde_expand PARAMS((int, int));
-extern int rl_vi_prev_word PARAMS((int, int));
-extern int rl_vi_next_word PARAMS((int, int));
-extern int rl_vi_end_word PARAMS((int, int));
-extern int rl_vi_insert_beg PARAMS((int, int));
-extern int rl_vi_append_mode PARAMS((int, int));
-extern int rl_vi_append_eol PARAMS((int, int));
-extern int rl_vi_eof_maybe PARAMS((int, int));
-extern int rl_vi_insertion_mode PARAMS((int, int));
-extern int rl_vi_insert_mode PARAMS((int, int));
-extern int rl_vi_movement_mode PARAMS((int, int));
-extern int rl_vi_arg_digit PARAMS((int, int));
-extern int rl_vi_change_case PARAMS((int, int));
-extern int rl_vi_put PARAMS((int, int));
-extern int rl_vi_column PARAMS((int, int));
-extern int rl_vi_delete_to PARAMS((int, int));
-extern int rl_vi_change_to PARAMS((int, int));
-extern int rl_vi_yank_to PARAMS((int, int));
-extern int rl_vi_rubout PARAMS((int, int));
-extern int rl_vi_delete PARAMS((int, int));
-extern int rl_vi_back_to_indent PARAMS((int, int));
-extern int rl_vi_first_print PARAMS((int, int));
-extern int rl_vi_char_search PARAMS((int, int));
-extern int rl_vi_match PARAMS((int, int));
-extern int rl_vi_change_char PARAMS((int, int));
-extern int rl_vi_subst PARAMS((int, int));
-extern int rl_vi_overstrike PARAMS((int, int));
-extern int rl_vi_overstrike_delete PARAMS((int, int));
-extern int rl_vi_replace PARAMS((int, int));
-extern int rl_vi_set_mark PARAMS((int, int));
-extern int rl_vi_goto_mark PARAMS((int, int));
+READLINE_EXPORT int rl_vi_redo PARAMS((int, int));
+READLINE_EXPORT int rl_vi_undo PARAMS((int, int));
+READLINE_EXPORT int rl_vi_yank_arg PARAMS((int, int));
+READLINE_EXPORT int rl_vi_fetch_history PARAMS((int, int));
+READLINE_EXPORT int rl_vi_search_again PARAMS((int, int));
+READLINE_EXPORT int rl_vi_search PARAMS((int, int));
+READLINE_EXPORT int rl_vi_complete PARAMS((int, int));
+READLINE_EXPORT int rl_vi_tilde_expand PARAMS((int, int));
+READLINE_EXPORT int rl_vi_prev_word PARAMS((int, int));
+READLINE_EXPORT int rl_vi_next_word PARAMS((int, int));
+READLINE_EXPORT int rl_vi_end_word PARAMS((int, int));
+READLINE_EXPORT int rl_vi_insert_beg PARAMS((int, int));
+READLINE_EXPORT int rl_vi_append_mode PARAMS((int, int));
+READLINE_EXPORT int rl_vi_append_eol PARAMS((int, int));
+READLINE_EXPORT int rl_vi_eof_maybe PARAMS((int, int));
+READLINE_EXPORT int rl_vi_insertion_mode PARAMS((int, int));
+READLINE_EXPORT int rl_vi_insert_mode PARAMS((int, int));
+READLINE_EXPORT int rl_vi_movement_mode PARAMS((int, int));
+READLINE_EXPORT int rl_vi_arg_digit PARAMS((int, int));
+READLINE_EXPORT int rl_vi_change_case PARAMS((int, int));
+READLINE_EXPORT int rl_vi_put PARAMS((int, int));
+READLINE_EXPORT int rl_vi_column PARAMS((int, int));
+READLINE_EXPORT int rl_vi_delete_to PARAMS((int, int));
+READLINE_EXPORT int rl_vi_change_to PARAMS((int, int));
+READLINE_EXPORT int rl_vi_yank_to PARAMS((int, int));
+READLINE_EXPORT int rl_vi_rubout PARAMS((int, int));
+READLINE_EXPORT int rl_vi_delete PARAMS((int, int));
+READLINE_EXPORT int rl_vi_back_to_indent PARAMS((int, int));
+READLINE_EXPORT int rl_vi_first_print PARAMS((int, int));
+READLINE_EXPORT int rl_vi_char_search PARAMS((int, int));
+READLINE_EXPORT int rl_vi_match PARAMS((int, int));
+READLINE_EXPORT int rl_vi_change_char PARAMS((int, int));
+READLINE_EXPORT int rl_vi_subst PARAMS((int, int));
+READLINE_EXPORT int rl_vi_overstrike PARAMS((int, int));
+READLINE_EXPORT int rl_vi_overstrike_delete PARAMS((int, int));
+READLINE_EXPORT int rl_vi_replace PARAMS((int, int));
+READLINE_EXPORT int rl_vi_set_mark PARAMS((int, int));
+READLINE_EXPORT int rl_vi_goto_mark PARAMS((int, int));
 
 /* VI-mode utility functions. */
-extern int rl_vi_check PARAMS((void));
-extern int rl_vi_domove PARAMS((int, int *));
-extern int rl_vi_bracktype PARAMS((int));
+READLINE_EXPORT int rl_vi_check PARAMS((void));
+READLINE_EXPORT int rl_vi_domove PARAMS((int, int *));
+READLINE_EXPORT int rl_vi_bracktype PARAMS((int));
 
-extern void rl_vi_start_inserting PARAMS((int, int, int));
+READLINE_EXPORT void rl_vi_start_inserting PARAMS((int, int, int));
 
 /* VI-mode pseudo-bindable commands, used as utility functions. */
-extern int rl_vi_fWord PARAMS((int, int));
-extern int rl_vi_bWord PARAMS((int, int));
-extern int rl_vi_eWord PARAMS((int, int));
-extern int rl_vi_fword PARAMS((int, int));
-extern int rl_vi_bword PARAMS((int, int));
-extern int rl_vi_eword PARAMS((int, int));
+READLINE_EXPORT int rl_vi_fWord PARAMS((int, int));
+READLINE_EXPORT int rl_vi_bWord PARAMS((int, int));
+READLINE_EXPORT int rl_vi_eWord PARAMS((int, int));
+READLINE_EXPORT int rl_vi_fword PARAMS((int, int));
+READLINE_EXPORT int rl_vi_bword PARAMS((int, int));
+READLINE_EXPORT int rl_vi_eword PARAMS((int, int));
 
 /* **************************************************************** */
 /*                                                                 */
@@ -284,195 +284,195 @@ extern int rl_vi_eword PARAMS((int, int));
 
 /* Readline functions. */
 /* Read a line of input.  Prompt with PROMPT.  A NULL PROMPT means none. */
-extern char *readline PARAMS((const char *));
+READLINE_EXPORT char *readline PARAMS((const char *));
 
-extern int rl_set_prompt PARAMS((const char *));
-extern int rl_expand_prompt PARAMS((char *));
+READLINE_EXPORT int rl_set_prompt PARAMS((const char *));
+READLINE_EXPORT int rl_expand_prompt PARAMS((char *));
 
-extern int rl_initialize PARAMS((void));
+READLINE_EXPORT int rl_initialize PARAMS((void));
 
 /* Undocumented; unused by readline */
-extern int rl_discard_argument PARAMS((void));
+READLINE_EXPORT int rl_discard_argument PARAMS((void));
 
 /* Utility functions to bind keys to readline commands. */
-extern int rl_add_defun PARAMS((const char *, rl_command_func_t *, int));
-extern int rl_bind_key PARAMS((int, rl_command_func_t *));
-extern int rl_bind_key_in_map PARAMS((int, rl_command_func_t *, Keymap));
-extern int rl_unbind_key PARAMS((int));
-extern int rl_unbind_key_in_map PARAMS((int, Keymap));
-extern int rl_bind_key_if_unbound PARAMS((int, rl_command_func_t *));
-extern int rl_bind_key_if_unbound_in_map PARAMS((int, rl_command_func_t *, 
Keymap));
-extern int rl_unbind_function_in_map PARAMS((rl_command_func_t *, Keymap));
-extern int rl_unbind_command_in_map PARAMS((const char *, Keymap));
-extern int rl_bind_keyseq PARAMS((const char *, rl_command_func_t *));
-extern int rl_bind_keyseq_in_map PARAMS((const char *, rl_command_func_t *, 
Keymap));
-extern int rl_bind_keyseq_if_unbound PARAMS((const char *, rl_command_func_t 
*));
-extern int rl_bind_keyseq_if_unbound_in_map PARAMS((const char *, 
rl_command_func_t *, Keymap));
-extern int rl_generic_bind PARAMS((int, const char *, char *, Keymap));
-
-extern char *rl_variable_value PARAMS((const char *));
-extern int rl_variable_bind PARAMS((const char *, const char *));
+READLINE_EXPORT int rl_add_defun PARAMS((const char *, rl_command_func_t *, 
int));
+READLINE_EXPORT int rl_bind_key PARAMS((int, rl_command_func_t *));
+READLINE_EXPORT int rl_bind_key_in_map PARAMS((int, rl_command_func_t *, 
Keymap));
+READLINE_EXPORT int rl_unbind_key PARAMS((int));
+READLINE_EXPORT int rl_unbind_key_in_map PARAMS((int, Keymap));
+READLINE_EXPORT int rl_bind_key_if_unbound PARAMS((int, rl_command_func_t *));
+READLINE_EXPORT int rl_bind_key_if_unbound_in_map PARAMS((int, 
rl_command_func_t *, Keymap));
+READLINE_EXPORT int rl_unbind_function_in_map PARAMS((rl_command_func_t *, 
Keymap));
+READLINE_EXPORT int rl_unbind_command_in_map PARAMS((const char *, Keymap));
+READLINE_EXPORT int rl_bind_keyseq PARAMS((const char *, rl_command_func_t *));
+READLINE_EXPORT int rl_bind_keyseq_in_map PARAMS((const char *, 
rl_command_func_t *, Keymap));
+READLINE_EXPORT int rl_bind_keyseq_if_unbound PARAMS((const char *, 
rl_command_func_t *));
+READLINE_EXPORT int rl_bind_keyseq_if_unbound_in_map PARAMS((const char *, 
rl_command_func_t *, Keymap));
+READLINE_EXPORT int rl_generic_bind PARAMS((int, const char *, char *, 
Keymap));
+
+READLINE_EXPORT char *rl_variable_value PARAMS((const char *));
+READLINE_EXPORT int rl_variable_bind PARAMS((const char *, const char *));
 
 /* Backwards compatibility, use rl_bind_keyseq_in_map instead. */
-extern int rl_set_key PARAMS((const char *, rl_command_func_t *, Keymap));
+READLINE_EXPORT int rl_set_key PARAMS((const char *, rl_command_func_t *, 
Keymap));
 
 /* Backwards compatibility, use rl_generic_bind instead. */
-extern int rl_macro_bind PARAMS((const char *, const char *, Keymap));
+READLINE_EXPORT int rl_macro_bind PARAMS((const char *, const char *, Keymap));
 
 /* Undocumented in the texinfo manual; not really useful to programs. */
-extern int rl_translate_keyseq PARAMS((const char *, char *, int *));
-extern char *rl_untranslate_keyseq PARAMS((int));
+READLINE_EXPORT int rl_translate_keyseq PARAMS((const char *, char *, int *));
+READLINE_EXPORT char *rl_untranslate_keyseq PARAMS((int));
 
-extern rl_command_func_t *rl_named_function PARAMS((const char *));
-extern rl_command_func_t *rl_function_of_keyseq PARAMS((const char *, Keymap, 
int *));
+READLINE_EXPORT rl_command_func_t *rl_named_function PARAMS((const char *));
+READLINE_EXPORT rl_command_func_t *rl_function_of_keyseq PARAMS((const char *, 
Keymap, int *));
 
-extern void rl_list_funmap_names PARAMS((void));
-extern char **rl_invoking_keyseqs_in_map PARAMS((rl_command_func_t *, Keymap));
-extern char **rl_invoking_keyseqs PARAMS((rl_command_func_t *));
+READLINE_EXPORT void rl_list_funmap_names PARAMS((void));
+READLINE_EXPORT char **rl_invoking_keyseqs_in_map PARAMS((rl_command_func_t *, 
Keymap));
+READLINE_EXPORT char **rl_invoking_keyseqs PARAMS((rl_command_func_t *));
  
-extern void rl_function_dumper PARAMS((int));
-extern void rl_macro_dumper PARAMS((int));
-extern void rl_variable_dumper PARAMS((int));
+READLINE_EXPORT void rl_function_dumper PARAMS((int));
+READLINE_EXPORT void rl_macro_dumper PARAMS((int));
+READLINE_EXPORT void rl_variable_dumper PARAMS((int));
 
-extern int rl_read_init_file PARAMS((const char *));
-extern int rl_parse_and_bind PARAMS((char *));
+READLINE_EXPORT int rl_read_init_file PARAMS((const char *));
+READLINE_EXPORT int rl_parse_and_bind PARAMS((char *));
 
 /* Functions for manipulating keymaps. */
-extern Keymap rl_make_bare_keymap PARAMS((void));
-extern Keymap rl_copy_keymap PARAMS((Keymap));
-extern Keymap rl_make_keymap PARAMS((void));
-extern void rl_discard_keymap PARAMS((Keymap));
-extern void rl_free_keymap PARAMS((Keymap));
-
-extern Keymap rl_get_keymap_by_name PARAMS((const char *));
-extern char *rl_get_keymap_name PARAMS((Keymap));
-extern void rl_set_keymap PARAMS((Keymap));
-extern Keymap rl_get_keymap PARAMS((void));
+READLINE_EXPORT Keymap rl_make_bare_keymap PARAMS((void));
+READLINE_EXPORT Keymap rl_copy_keymap PARAMS((Keymap));
+READLINE_EXPORT Keymap rl_make_keymap PARAMS((void));
+READLINE_EXPORT void rl_discard_keymap PARAMS((Keymap));
+READLINE_EXPORT void rl_free_keymap PARAMS((Keymap));
+
+READLINE_EXPORT Keymap rl_get_keymap_by_name PARAMS((const char *));
+READLINE_EXPORT char *rl_get_keymap_name PARAMS((Keymap));
+READLINE_EXPORT void rl_set_keymap PARAMS((Keymap));
+READLINE_EXPORT Keymap rl_get_keymap PARAMS((void));
 /* Undocumented; used internally only. */
-extern void rl_set_keymap_from_edit_mode PARAMS((void));
-extern char *rl_get_keymap_name_from_edit_mode PARAMS((void));
+READLINE_EXPORT void rl_set_keymap_from_edit_mode PARAMS((void));
+READLINE_EXPORT char *rl_get_keymap_name_from_edit_mode PARAMS((void));
 
 /* Functions for manipulating the funmap, which maps command names to 
functions. */
-extern int rl_add_funmap_entry PARAMS((const char *, rl_command_func_t *));
-extern const char **rl_funmap_names PARAMS((void));
+READLINE_EXPORT int rl_add_funmap_entry PARAMS((const char *, 
rl_command_func_t *));
+READLINE_EXPORT const char **rl_funmap_names PARAMS((void));
 /* Undocumented, only used internally -- there is only one funmap, and this
    function may be called only once. */
-extern void rl_initialize_funmap PARAMS((void));
+READLINE_EXPORT void rl_initialize_funmap PARAMS((void));
 
 /* Utility functions for managing keyboard macros. */
-extern void rl_push_macro_input PARAMS((char *));
+READLINE_EXPORT void rl_push_macro_input PARAMS((char *));
 
 /* Functions for undoing, from undo.c */
-extern void rl_add_undo PARAMS((enum undo_code, int, int, char *));
-extern void rl_free_undo_list PARAMS((void));
-extern int rl_do_undo PARAMS((void));
-extern int rl_begin_undo_group PARAMS((void));
-extern int rl_end_undo_group PARAMS((void));
-extern int rl_modifying PARAMS((int, int));
+READLINE_EXPORT void rl_add_undo PARAMS((enum undo_code, int, int, char *));
+READLINE_EXPORT void rl_free_undo_list PARAMS((void));
+READLINE_EXPORT int rl_do_undo PARAMS((void));
+READLINE_EXPORT int rl_begin_undo_group PARAMS((void));
+READLINE_EXPORT int rl_end_undo_group PARAMS((void));
+READLINE_EXPORT int rl_modifying PARAMS((int, int));
 
 /* Functions for redisplay. */
-extern void rl_redisplay PARAMS((void));
-extern int rl_on_new_line PARAMS((void));
-extern int rl_on_new_line_with_prompt PARAMS((void));
-extern int rl_forced_update_display PARAMS((void));
-extern int rl_clear_message PARAMS((void));
-extern int rl_reset_line_state PARAMS((void));
-extern int rl_crlf PARAMS((void));
+READLINE_EXPORT void rl_redisplay PARAMS((void));
+READLINE_EXPORT int rl_on_new_line PARAMS((void));
+READLINE_EXPORT int rl_on_new_line_with_prompt PARAMS((void));
+READLINE_EXPORT int rl_forced_update_display PARAMS((void));
+READLINE_EXPORT int rl_clear_message PARAMS((void));
+READLINE_EXPORT int rl_reset_line_state PARAMS((void));
+READLINE_EXPORT int rl_crlf PARAMS((void));
 
 #if defined (USE_VARARGS) && defined (PREFER_STDARG)
-extern int rl_message (const char *, ...)  __attribute__((__format__ (printf, 
1, 2)));
+READLINE_EXPORT int rl_message (const char *, ...)  __attribute__((__format__ 
(printf, 1, 2)));
 #else
-extern int rl_message ();
+READLINE_EXPORT int rl_message ();
 #endif
 
-extern int rl_show_char PARAMS((int));
+READLINE_EXPORT int rl_show_char PARAMS((int));
 
 /* Undocumented in texinfo manual. */
-extern int rl_character_len PARAMS((int, int));
+READLINE_EXPORT int rl_character_len PARAMS((int, int));
 
 /* Save and restore internal prompt redisplay information. */
-extern void rl_save_prompt PARAMS((void));
-extern void rl_restore_prompt PARAMS((void));
+READLINE_EXPORT void rl_save_prompt PARAMS((void));
+READLINE_EXPORT void rl_restore_prompt PARAMS((void));
 
 /* Modifying text. */
-extern void rl_replace_line PARAMS((const char *, int));
-extern int rl_insert_text PARAMS((const char *));
-extern int rl_delete_text PARAMS((int, int));
-extern int rl_kill_text PARAMS((int, int));
-extern char *rl_copy_text PARAMS((int, int));
+READLINE_EXPORT void rl_replace_line PARAMS((const char *, int));
+READLINE_EXPORT int rl_insert_text PARAMS((const char *));
+READLINE_EXPORT int rl_delete_text PARAMS((int, int));
+READLINE_EXPORT int rl_kill_text PARAMS((int, int));
+READLINE_EXPORT char *rl_copy_text PARAMS((int, int));
 
 /* Terminal and tty mode management. */
-extern void rl_prep_terminal PARAMS((int));
-extern void rl_deprep_terminal PARAMS((void));
-extern void rl_tty_set_default_bindings PARAMS((Keymap));
-extern void rl_tty_unset_default_bindings PARAMS((Keymap));
+READLINE_EXPORT void rl_prep_terminal PARAMS((int));
+READLINE_EXPORT void rl_deprep_terminal PARAMS((void));
+READLINE_EXPORT void rl_tty_set_default_bindings PARAMS((Keymap));
+READLINE_EXPORT void rl_tty_unset_default_bindings PARAMS((Keymap));
 
-extern int rl_reset_terminal PARAMS((const char *));
-extern void rl_resize_terminal PARAMS((void));
-extern void rl_set_screen_size PARAMS((int, int));
-extern void rl_get_screen_size PARAMS((int *, int *));
-extern void rl_reset_screen_size PARAMS((void));
+READLINE_EXPORT int rl_reset_terminal PARAMS((const char *));
+READLINE_EXPORT void rl_resize_terminal PARAMS((void));
+READLINE_EXPORT void rl_set_screen_size PARAMS((int, int));
+READLINE_EXPORT void rl_get_screen_size PARAMS((int *, int *));
+READLINE_EXPORT void rl_reset_screen_size PARAMS((void));
 
-extern char *rl_get_termcap PARAMS((const char *));
+READLINE_EXPORT char *rl_get_termcap PARAMS((const char *));
 
 /* Functions for character input. */
-extern int rl_stuff_char PARAMS((int));
-extern int rl_execute_next PARAMS((int));
-extern int rl_clear_pending_input PARAMS((void));
-extern int rl_read_key PARAMS((void));
-extern int rl_getc PARAMS((FILE *));
-extern int rl_set_keyboard_input_timeout PARAMS((int));
+READLINE_EXPORT int rl_stuff_char PARAMS((int));
+READLINE_EXPORT int rl_execute_next PARAMS((int));
+READLINE_EXPORT int rl_clear_pending_input PARAMS((void));
+READLINE_EXPORT int rl_read_key PARAMS((void));
+READLINE_EXPORT int rl_getc PARAMS((FILE *));
+READLINE_EXPORT int rl_set_keyboard_input_timeout PARAMS((int));
 
 /* `Public' utility functions . */
-extern void rl_extend_line_buffer PARAMS((int));
-extern int rl_ding PARAMS((void));
-extern int rl_alphabetic PARAMS((int));
-extern void rl_free PARAMS((void *));
+READLINE_EXPORT void rl_extend_line_buffer PARAMS((int));
+READLINE_EXPORT int rl_ding PARAMS((void));
+READLINE_EXPORT int rl_alphabetic PARAMS((int));
+READLINE_EXPORT void rl_free PARAMS((void *));
 
 /* Readline signal handling, from signals.c */
-extern int rl_set_signals PARAMS((void));
-extern int rl_clear_signals PARAMS((void));
-extern void rl_cleanup_after_signal PARAMS((void));
-extern void rl_reset_after_signal PARAMS((void));
-extern void rl_free_line_state PARAMS((void));
+READLINE_EXPORT int rl_set_signals PARAMS((void));
+READLINE_EXPORT int rl_clear_signals PARAMS((void));
+READLINE_EXPORT void rl_cleanup_after_signal PARAMS((void));
+READLINE_EXPORT void rl_reset_after_signal PARAMS((void));
+READLINE_EXPORT void rl_free_line_state PARAMS((void));
 
-extern void rl_echo_signal_char PARAMS((int)); 
+READLINE_EXPORT void rl_echo_signal_char PARAMS((int)); 
 
-extern int rl_set_paren_blink_timeout PARAMS((int));
+READLINE_EXPORT int rl_set_paren_blink_timeout PARAMS((int));
 
 /* History management functions. */
 
-extern void rl_clear_history PARAMS((void));
+READLINE_EXPORT void rl_clear_history PARAMS((void));
 
 /* Undocumented. */
-extern int rl_maybe_save_line PARAMS((void));
-extern int rl_maybe_unsave_line PARAMS((void));
-extern int rl_maybe_replace_line PARAMS((void));
+READLINE_EXPORT int rl_maybe_save_line PARAMS((void));
+READLINE_EXPORT int rl_maybe_unsave_line PARAMS((void));
+READLINE_EXPORT int rl_maybe_replace_line PARAMS((void));
 
 /* Completion functions. */
-extern int rl_complete_internal PARAMS((int));
-extern void rl_display_match_list PARAMS((char **, int, int));
+READLINE_EXPORT int rl_complete_internal PARAMS((int));
+READLINE_EXPORT void rl_display_match_list PARAMS((char **, int, int));
 
-extern char **rl_completion_matches PARAMS((const char *, rl_compentry_func_t 
*));
-extern char *rl_username_completion_function PARAMS((const char *, int));
-extern char *rl_filename_completion_function PARAMS((const char *, int));
+READLINE_EXPORT char **rl_completion_matches PARAMS((const char *, 
rl_compentry_func_t *));
+READLINE_EXPORT char *rl_username_completion_function PARAMS((const char *, 
int));
+READLINE_EXPORT char *rl_filename_completion_function PARAMS((const char *, 
int));
 
-extern int rl_completion_mode PARAMS((rl_command_func_t *));
+READLINE_EXPORT int rl_completion_mode PARAMS((rl_command_func_t *));
 
 #if 0
 /* Backwards compatibility (compat.c).  These will go away sometime. */
-extern void free_undo_list PARAMS((void));
-extern int maybe_save_line PARAMS((void));
-extern int maybe_unsave_line PARAMS((void));
-extern int maybe_replace_line PARAMS((void));
-
-extern int ding PARAMS((void));
-extern int alphabetic PARAMS((int));
-extern int crlf PARAMS((void));
-
-extern char **completion_matches PARAMS((char *, rl_compentry_func_t *));
-extern char *username_completion_function PARAMS((const char *, int));
-extern char *filename_completion_function PARAMS((const char *, int));
+READLINE_EXPORT void free_undo_list PARAMS((void));
+READLINE_EXPORT int maybe_save_line PARAMS((void));
+READLINE_EXPORT int maybe_unsave_line PARAMS((void));
+READLINE_EXPORT int maybe_replace_line PARAMS((void));
+
+READLINE_EXPORT int ding PARAMS((void));
+READLINE_EXPORT int alphabetic PARAMS((int));
+READLINE_EXPORT int crlf PARAMS((void));
+
+READLINE_EXPORT char **completion_matches PARAMS((char *, rl_compentry_func_t 
*));
+READLINE_EXPORT char *username_completion_function PARAMS((const char *, int));
+READLINE_EXPORT char *filename_completion_function PARAMS((const char *, int));
 #endif
 
 /* **************************************************************** */
@@ -482,155 +482,155 @@ extern char *filename_completion_function PARAMS((const 
char *, int));
 /* **************************************************************** */
 
 /* The version of this incarnation of the readline library. */
-extern const char *rl_library_version;         /* e.g., "4.2" */
-extern int rl_readline_version;                        /* e.g., 0x0402 */
+READLINE_EXPORT const char *rl_library_version;                /* e.g., "4.2" 
*/
+READLINE_EXPORT int rl_readline_version;                       /* e.g., 0x0402 
*/
 
 /* True if this is real GNU readline. */
-extern int rl_gnu_readline_p;
+READLINE_EXPORT int rl_gnu_readline_p;
 
 /* Flags word encapsulating the current readline state. */
-extern int rl_readline_state;
+READLINE_EXPORT int rl_readline_state;
 
 /* Says which editing mode readline is currently using.  1 means emacs mode;
    0 means vi mode. */
-extern int rl_editing_mode;
+READLINE_EXPORT int rl_editing_mode;
 
 /* Insert or overwrite mode for emacs mode.  1 means insert mode; 0 means
    overwrite mode.  Reset to insert mode on each input line. */
-extern int rl_insert_mode;
+READLINE_EXPORT int rl_insert_mode;
 
 /* The name of the calling program.  You should initialize this to
    whatever was in argv[0].  It is used when parsing conditionals. */
-extern const char *rl_readline_name;
+READLINE_EXPORT const char *rl_readline_name;
 
 /* The prompt readline uses.  This is set from the argument to
    readline (), and should not be assigned to directly. */
-extern char *rl_prompt;
+READLINE_EXPORT char *rl_prompt;
 
 /* The prompt string that is actually displayed by rl_redisplay.  Public so
    applications can more easily supply their own redisplay functions. */
-extern char *rl_display_prompt;
+READLINE_EXPORT char *rl_display_prompt;
 
 /* The line buffer that is in use. */
-extern char *rl_line_buffer;
+READLINE_EXPORT char *rl_line_buffer;
 
 /* The location of point, and end. */
-extern int rl_point;
-extern int rl_end;
+READLINE_EXPORT int rl_point;
+READLINE_EXPORT int rl_end;
 
 /* The mark, or saved cursor position. */
-extern int rl_mark;
+READLINE_EXPORT int rl_mark;
 
 /* Flag to indicate that readline has finished with the current input
    line and should return it. */
-extern int rl_done;
+READLINE_EXPORT int rl_done;
 
 /* If set to a character value, that will be the next keystroke read. */
-extern int rl_pending_input;
+READLINE_EXPORT int rl_pending_input;
 
 /* Non-zero if we called this function from _rl_dispatch().  It's present
    so functions can find out whether they were called from a key binding
    or directly from an application. */
-extern int rl_dispatching;
+READLINE_EXPORT int rl_dispatching;
 
 /* Non-zero if the user typed a numeric argument before executing the
    current function. */
-extern int rl_explicit_arg;
+READLINE_EXPORT int rl_explicit_arg;
 
 /* The current value of the numeric argument specified by the user. */
-extern int rl_numeric_arg;
+READLINE_EXPORT int rl_numeric_arg;
 
 /* The address of the last command function Readline executed. */
-extern rl_command_func_t *rl_last_func;
+READLINE_EXPORT rl_command_func_t *rl_last_func;
 
 /* The name of the terminal to use. */
-extern const char *rl_terminal_name;
+READLINE_EXPORT const char *rl_terminal_name;
 
 /* The input and output streams. */
-extern FILE *rl_instream;
-extern FILE *rl_outstream;
+READLINE_EXPORT FILE *rl_instream;
+READLINE_EXPORT FILE *rl_outstream;
 
 /* If non-zero, Readline gives values of LINES and COLUMNS from the environment
    greater precedence than values fetched from the kernel when computing the
    screen dimensions. */
-extern int rl_prefer_env_winsize;
+READLINE_EXPORT int rl_prefer_env_winsize;
 
 /* If non-zero, then this is the address of a function to call just
    before readline_internal () prints the first prompt. */
-extern rl_hook_func_t *rl_startup_hook;
+READLINE_EXPORT rl_hook_func_t *rl_startup_hook;
 
 /* If non-zero, this is the address of a function to call just before
    readline_internal_setup () returns and readline_internal starts
    reading input characters. */
-extern rl_hook_func_t *rl_pre_input_hook;
+READLINE_EXPORT rl_hook_func_t *rl_pre_input_hook;
       
 /* The address of a function to call periodically while Readline is
    awaiting character input, or NULL, for no event handling. */
-extern rl_hook_func_t *rl_event_hook;
+READLINE_EXPORT rl_hook_func_t *rl_event_hook;
 
 /* The address of a function to call if a read is interrupted by a signal. */
-extern rl_hook_func_t *rl_signal_event_hook;
+READLINE_EXPORT rl_hook_func_t *rl_signal_event_hook;
 
 /* The address of a function to call if Readline needs to know whether or not
    there is data available from the current input source. */
-extern rl_hook_func_t *rl_input_available_hook;
+READLINE_EXPORT rl_hook_func_t *rl_input_available_hook;
 
 /* The address of the function to call to fetch a character from the current
    Readline input stream */
-extern rl_getc_func_t *rl_getc_function;
+READLINE_EXPORT rl_getc_func_t *rl_getc_function;
 
-extern rl_voidfunc_t *rl_redisplay_function;
+READLINE_EXPORT rl_voidfunc_t *rl_redisplay_function;
 
-extern rl_vintfunc_t *rl_prep_term_function;
-extern rl_voidfunc_t *rl_deprep_term_function;
+READLINE_EXPORT rl_vintfunc_t *rl_prep_term_function;
+READLINE_EXPORT rl_voidfunc_t *rl_deprep_term_function;
 
 /* Dispatch variables. */
-extern Keymap rl_executing_keymap;
-extern Keymap rl_binding_keymap;
+READLINE_EXPORT Keymap rl_executing_keymap;
+READLINE_EXPORT Keymap rl_binding_keymap;
 
-extern int rl_executing_key;
-extern char *rl_executing_keyseq;
-extern int rl_key_sequence_length;
+READLINE_EXPORT int rl_executing_key;
+READLINE_EXPORT char *rl_executing_keyseq;
+READLINE_EXPORT int rl_key_sequence_length;
 
 /* Display variables. */
 /* If non-zero, readline will erase the entire line, including any prompt,
    if the only thing typed on an otherwise-blank line is something bound to
    rl_newline. */
-extern int rl_erase_empty_line;
+READLINE_EXPORT int rl_erase_empty_line;
 
 /* If non-zero, the application has already printed the prompt (rl_prompt)
    before calling readline, so readline should not output it the first time
    redisplay is done. */
-extern int rl_already_prompted;
+READLINE_EXPORT int rl_already_prompted;
 
 /* A non-zero value means to read only this many characters rather than
    up to a character bound to accept-line. */
-extern int rl_num_chars_to_read;
+READLINE_EXPORT int rl_num_chars_to_read;
 
 /* The text of a currently-executing keyboard macro. */
-extern char *rl_executing_macro;
+READLINE_EXPORT char *rl_executing_macro;
 
 /* Variables to control readline signal handling. */
 /* If non-zero, readline will install its own signal handlers for
    SIGINT, SIGTERM, SIGQUIT, SIGALRM, SIGTSTP, SIGTTIN, and SIGTTOU. */
-extern int rl_catch_signals;
+READLINE_EXPORT int rl_catch_signals;
 
 /* If non-zero, readline will install a signal handler for SIGWINCH
    that also attempts to call any calling application's SIGWINCH signal
    handler.  Note that the terminal is not cleaned up before the
    application's signal handler is called; use rl_cleanup_after_signal()
    to do that. */
-extern int rl_catch_sigwinch;
+READLINE_EXPORT int rl_catch_sigwinch;
 
 /* If non-zero, the readline SIGWINCH handler will modify LINES and
    COLUMNS in the environment. */
-extern int rl_change_environment;
+READLINE_EXPORT int rl_change_environment;
 
 /* Completion variables. */
 /* Pointer to the generator function for completion_matches ().
    NULL means to use rl_filename_completion_function (), the default
    filename completer. */
-extern rl_compentry_func_t *rl_completion_entry_function;
+READLINE_EXPORT rl_compentry_func_t *rl_completion_entry_function;
 
 /* Optional generator for menu completion.  Default is
    rl_completion_entry_function (rl_filename_completion_function). */
@@ -642,7 +642,7 @@ extern rl_compentry_func_t *rl_completion_entry_function;
    The function is called with one argument; a NULL terminated array
    of (char *).  If your function removes any of the elements, they
    must be free()'ed. */
-extern rl_compignore_func_t *rl_ignore_some_completions_function;
+READLINE_EXPORT rl_compignore_func_t *rl_ignore_some_completions_function;
 
 /* Pointer to alternative function to create matches.
    Function is called with TEXT, START, and END.
@@ -651,39 +651,39 @@ extern rl_compignore_func_t 
*rl_ignore_some_completions_function;
    If this function exists and returns NULL then call the value of
    rl_completion_entry_function to try to match, otherwise use the
    array of strings returned. */
-extern rl_completion_func_t *rl_attempted_completion_function;
+READLINE_EXPORT rl_completion_func_t *rl_attempted_completion_function;
 
 /* The basic list of characters that signal a break between words for the
    completer routine.  The initial contents of this variable is what
    breaks words in the shell, i.e. "n\"\\'address@hidden>". */
-extern const char *rl_basic_word_break_characters;
+READLINE_EXPORT const char *rl_basic_word_break_characters;
 
 /* The list of characters that signal a break between words for
    rl_complete_internal.  The default list is the contents of
    rl_basic_word_break_characters.  */
-extern /*const*/ char *rl_completer_word_break_characters;
+READLINE_EXPORT /*const*/ char *rl_completer_word_break_characters;
 
 /* Hook function to allow an application to set the completion word
    break characters before readline breaks up the line.  Allows
    position-dependent word break characters. */
-extern rl_cpvfunc_t *rl_completion_word_break_hook;
+READLINE_EXPORT rl_cpvfunc_t *rl_completion_word_break_hook;
 
 /* List of characters which can be used to quote a substring of the line.
    Completion occurs on the entire substring, and within the substring   
    rl_completer_word_break_characters are treated as any other character,
    unless they also appear within this list. */
-extern const char *rl_completer_quote_characters;
+READLINE_EXPORT const char *rl_completer_quote_characters;
 
 /* List of quote characters which cause a word break. */
-extern const char *rl_basic_quote_characters;
+READLINE_EXPORT const char *rl_basic_quote_characters;
 
 /* List of characters that need to be quoted in filenames by the completer. */
-extern const char *rl_filename_quote_characters;
+READLINE_EXPORT const char *rl_filename_quote_characters;
 
 /* List of characters that are word break characters, but should be left
    in TEXT when it is passed to the completion function.  The shell uses
    this to help determine what kind of completing to do. */
-extern const char *rl_special_prefixes;
+READLINE_EXPORT const char *rl_special_prefixes;
 
 /* If non-zero, then this is the address of a function to call when
    completing on a directory name.  The function is called with
@@ -694,7 +694,7 @@ extern const char *rl_special_prefixes;
    the directory name pointer passed as an argument.  If the directory
    completion hook returns 0, it should not modify the directory name
    pointer passed as an argument. */
-extern rl_icppfunc_t *rl_directory_completion_hook;
+READLINE_EXPORT rl_icppfunc_t *rl_directory_completion_hook;
 
 /* If non-zero, this is the address of a function to call when completing
    a directory name.  This function takes the address of the directory name
@@ -707,14 +707,14 @@ extern rl_icppfunc_t *rl_directory_completion_hook;
 
    I'm not happy with how this works yet, so it's undocumented.  I'm trying
    it in bash to see how well it goes. */
-extern rl_icppfunc_t *rl_directory_rewrite_hook;
+READLINE_EXPORT rl_icppfunc_t *rl_directory_rewrite_hook;
 
 /* If non-zero, this is the address of a function for the completer to call
    before deciding which character to append to a completed name.  It should
    modify the directory name passed as an argument if appropriate, and return
    non-zero if it modifies the name.  This should not worry about dequoting
    the filename; that has already happened by the time it gets here. */
-extern rl_icppfunc_t *rl_filename_stat_hook;
+READLINE_EXPORT rl_icppfunc_t *rl_filename_stat_hook;
 
 /* If non-zero, this is the address of a function to call when reading
    directory entries from the filesystem for completion and comparing
@@ -725,7 +725,7 @@ extern rl_icppfunc_t *rl_filename_stat_hook;
    keyboard.  The returned value is what is added to the list of
    matches.  The second argument is the length of the filename to be
    converted. */
-extern rl_dequote_func_t *rl_filename_rewrite_hook;
+READLINE_EXPORT rl_dequote_func_t *rl_filename_rewrite_hook;
 
 /* Backwards compatibility with previous versions of readline. */
 #define rl_symbolic_link_hook rl_directory_completion_hook
@@ -737,76 +737,76 @@ extern rl_dequote_func_t *rl_filename_rewrite_hook;
    where MATCHES is the array of strings that matched, NUM_MATCHES is the
    number of strings in that array, and MAX_LENGTH is the length of the
    longest string in that array. */
-extern rl_compdisp_func_t *rl_completion_display_matches_hook;
+READLINE_EXPORT rl_compdisp_func_t *rl_completion_display_matches_hook;
 
 /* Non-zero means that the results of the matches are to be treated
    as filenames.  This is ALWAYS zero on entry, and can only be changed
    within a completion entry finder function. */
-extern int rl_filename_completion_desired;
+READLINE_EXPORT int rl_filename_completion_desired;
 
 /* Non-zero means that the results of the matches are to be quoted using
    double quotes (or an application-specific quoting mechanism) if the
    filename contains any characters in rl_word_break_chars.  This is
    ALWAYS non-zero on entry, and can only be changed within a completion
    entry finder function. */
-extern int rl_filename_quoting_desired;
+READLINE_EXPORT int rl_filename_quoting_desired;
 
 /* Set to a function to quote a filename in an application-specific fashion.
    Called with the text to quote, the type of match found (single or multiple)
    and a pointer to the quoting character to be used, which the function can
    reset if desired. */
-extern rl_quote_func_t *rl_filename_quoting_function;
+READLINE_EXPORT rl_quote_func_t *rl_filename_quoting_function;
 
 /* Function to call to remove quoting characters from a filename.  Called
    before completion is attempted, so the embedded quotes do not interfere
    with matching names in the file system. */
-extern rl_dequote_func_t *rl_filename_dequoting_function;
+READLINE_EXPORT rl_dequote_func_t *rl_filename_dequoting_function;
 
 /* Function to call to decide whether or not a word break character is
    quoted.  If a character is quoted, it does not break words for the
    completer. */
-extern rl_linebuf_func_t *rl_char_is_quoted_p;
+READLINE_EXPORT rl_linebuf_func_t *rl_char_is_quoted_p;
 
 /* Non-zero means to suppress normal filename completion after the
    user-specified completion function has been called. */
-extern int rl_attempted_completion_over;
+READLINE_EXPORT int rl_attempted_completion_over;
 
 /* Set to a character describing the type of completion being attempted by
    rl_complete_internal; available for use by application completion
    functions. */
-extern int rl_completion_type;
+READLINE_EXPORT int rl_completion_type;
 
 /* Set to the last key used to invoke one of the completion functions */
-extern int rl_completion_invoking_key;
+READLINE_EXPORT int rl_completion_invoking_key;
 
 /* Up to this many items will be displayed in response to a
    possible-completions call.  After that, we ask the user if she
    is sure she wants to see them all.  The default value is 100. */
-extern int rl_completion_query_items;
+READLINE_EXPORT int rl_completion_query_items;
 
 /* Character appended to completed words when at the end of the line.  The
    default is a space.  Nothing is added if this is '\0'. */
-extern int rl_completion_append_character;
+READLINE_EXPORT int rl_completion_append_character;
 
 /* If set to non-zero by an application completion function,
    rl_completion_append_character will not be appended. */
-extern int rl_completion_suppress_append;
+READLINE_EXPORT int rl_completion_suppress_append;
 
 /* Set to any quote character readline thinks it finds before any application
    completion function is called. */
-extern int rl_completion_quote_character;
+READLINE_EXPORT int rl_completion_quote_character;
 
 /* Set to a non-zero value if readline found quoting anywhere in the word to
    be completed; set before any application completion function is called. */
-extern int rl_completion_found_quote;
+READLINE_EXPORT int rl_completion_found_quote;
 
 /* If non-zero, the completion functions don't append any closing quote.
    This is set to 0 by rl_complete_internal and may be changed by an
    application-specific completion function. */
-extern int rl_completion_suppress_quote;
+READLINE_EXPORT int rl_completion_suppress_quote;
 
 /* If non-zero, readline will sort the completion matches.  On by default. */
-extern int rl_sort_completion_matches;
+READLINE_EXPORT int rl_sort_completion_matches;
 
 /* If non-zero, a slash will be appended to completed filenames that are
    symbolic links to directory names, subject to the value of the
@@ -817,14 +817,14 @@ extern int rl_sort_completion_matches;
    rl_complete_internal before any application-specific completion
    function is called, so without that function doing anything, the user's
    preferences are honored. */
-extern int rl_completion_mark_symlink_dirs;
+READLINE_EXPORT int rl_completion_mark_symlink_dirs;
 
 /* If non-zero, then disallow duplicates in the matches. */
-extern int rl_ignore_completion_duplicates;
+READLINE_EXPORT int rl_ignore_completion_duplicates;
 
 /* If this is non-zero, completion is (temporarily) inhibited, and the
    completion character will be inserted as any other. */
-extern int rl_inhibit_completion;
+READLINE_EXPORT int rl_inhibit_completion;
 
 /* Input error; can be returned by (*rl_getc_function) if readline is reading
    a top-level command (RL_ISSTATE (RL_STATE_READCMD)). */
@@ -913,8 +913,8 @@ struct readline_state {
   char reserved[64];
 };
 
-extern int rl_save_state PARAMS((struct readline_state *));
-extern int rl_restore_state PARAMS((struct readline_state *));
+READLINE_EXPORT int rl_save_state PARAMS((struct readline_state *));
+READLINE_EXPORT int rl_restore_state PARAMS((struct readline_state *));
 
 #ifdef __cplusplus
 }
diff --git a/rlstdc.h b/rlstdc.h
index 2aaa30b..401bde9 100644
--- a/rlstdc.h
+++ b/rlstdc.h
@@ -54,4 +54,10 @@
 #  endif
 #endif
 
+#if defined(HAVE_VISIBILITY) && HAVE_VISIBILITY
+#define READLINE_EXPORT extern __attribute__((visibility("default")))
+#else
+#define READLINE_EXPORT extern
+#endif
+
 #endif /* !_RL_STDC_H_ */
diff --git a/shlib/Makefile.in b/shlib/Makefile.in
index eb16211..2d0515a 100644
--- a/shlib/Makefile.in
+++ b/shlib/Makefile.in
@@ -65,6 +65,7 @@ DESTDIR =
 
 CFLAGS = @CFLAGS@
 LOCAL_CFLAGS = @LOCAL_CFLAGS@ -DRL_LIBRARY_VERSION='"$(RL_LIBRARY_VERSION)"'
+CFLAGS_VISIBILITY = @CFLAGS_VISIBILITY@
 CPPFLAGS = @CPPFLAGS@
 LDFLAGS = @LDFLAGS@ @LOCAL_LDFLAGS@ @CFLAGS@
 
@@ -107,7 +108,7 @@ SHLIB_MINOR=                address@hidden@
 # For libraries which include headers from other libraries.
 INCLUDES = -I. -I.. -I$(topdir)
 
-CCFLAGS = $(DEFS) $(LOCAL_DEFS) $(CPPFLAGS) $(INCLUDES) $(LOCAL_CFLAGS) 
$(CFLAGS)
+CCFLAGS = $(DEFS) $(LOCAL_DEFS) $(CPPFLAGS) $(INCLUDES) $(LOCAL_CFLAGS) 
$(CFLAGS) $(CFLAGS_VISIBILITY)
 
 .SUFFIXES:     .so
 
diff --git a/tilde.h b/tilde.h
index e26dd04..a10d177 100644
--- a/tilde.h
+++ b/tilde.h
@@ -27,6 +27,12 @@
 extern "C" {
 #endif
 
+#if defined READLINE_LIBRARY
+#  include "rlstdc.h"
+#else
+#  include <readline/rlstdc.h>
+#endif
+
 /* A function can be defined using prototypes and compile on both ANSI C
    and traditional C compilers with something like this:
        extern char *func PARAMS((char *, char *, int)); */
@@ -45,33 +51,33 @@ typedef char *tilde_hook_func_t PARAMS((char *));
    wants called before trying the standard tilde expansions.  The function
    is called with the text sans tilde, and returns a malloc()'ed string
    which is the expansion, or a NULL pointer if the expansion fails. */
-extern tilde_hook_func_t *tilde_expansion_preexpansion_hook;
+READLINE_EXPORT tilde_hook_func_t *tilde_expansion_preexpansion_hook;
 
 /* If non-null, this contains the address of a function to call if the
    standard meaning for expanding a tilde fails.  The function is called
    with the text (sans tilde, as in "foo"), and returns a malloc()'ed string
    which is the expansion, or a NULL pointer if there is no expansion. */
-extern tilde_hook_func_t *tilde_expansion_failure_hook;
+READLINE_EXPORT tilde_hook_func_t *tilde_expansion_failure_hook;
 
 /* When non-null, this is a NULL terminated array of strings which
    are duplicates for a tilde prefix.  Bash uses this to expand
    `=~' and `:~'. */
-extern char **tilde_additional_prefixes;
+READLINE_EXPORT char **tilde_additional_prefixes;
 
 /* When non-null, this is a NULL terminated array of strings which match
    the end of a username, instead of just "/".  Bash sets this to
    `:' and `=~'. */
-extern char **tilde_additional_suffixes;
+READLINE_EXPORT char **tilde_additional_suffixes;
 
 /* Return a new string which is the result of tilde expanding STRING. */
-extern char *tilde_expand PARAMS((const char *));
+READLINE_EXPORT char *tilde_expand PARAMS((const char *));
 
 /* Do the work of tilde expansion on FILENAME.  FILENAME starts with a
    tilde.  If there is no expansion, call tilde_expansion_failure_hook. */
-extern char *tilde_expand_word PARAMS((const char *));
+READLINE_EXPORT char *tilde_expand_word PARAMS((const char *));
 
 /* Find the portion of the string beginning with ~ that should be expanded. */
-extern char *tilde_find_word PARAMS((const char *, int, int *));
+READLINE_EXPORT char *tilde_find_word PARAMS((const char *, int, int *));
 
 #ifdef __cplusplus
 }
-- 
1.9.1

>From ee2579eacc90770c9321778a0e7c0c5da80b1690 Mon Sep 17 00:00:00 2001
From: Yury Gribov <address@hidden>
Date: Wed, 13 Apr 2016 17:06:27 +0300
Subject: [PATCH 2/3] Regenerated configure.

---
 configure | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/configure b/configure
index f11ee25..be99fe3 100755
--- a/configure
+++ b/configure
@@ -633,6 +633,7 @@ SHOBJ_LDFLAGS
 SHOBJ_LD
 SHOBJ_CFLAGS
 SHOBJ_CC
+CFLAGS_VISIBILITY
 LIBOBJS
 MAKE_SHELL
 RANLIB
@@ -6395,6 +6396,28 @@ case "$host_os" in
 isc*)  LOCAL_CFLAGS=-Disc386 ;;
 esac
 
+save_CFLAGS="$CFLAGS"
+CFLAGS="$CFLAGS -fvisibility=hidden"
+CFLAGS_VISIBILITY=
+HAVE_VISIBILITY=0
+cat confdefs.h - <<_ACEOF >conftest.$ac_ext
+/* end confdefs.h.  */
+
+    #if defined(__CYGWIN__) || defined(__MINGW32__)
+    #error No visibility support
+    #endif
+    extern __attribute__((__visibility__("default"))) int x;
+
+_ACEOF
+if ac_fn_c_try_compile "$LINENO"; then :
+  CFLAGS_VISIBILITY=-fvisibility=hidden
+   $as_echo "#define HAVE_VISIBILITY 1" >>confdefs.h
+
+fi
+rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
+CFLAGS="$save_CFLAGS"
+
+
 # shared library configuration section
 #
 # Shared object configuration section.  These values are generated by
-- 
1.9.1

>From a754844401a750927be8d936ce530fe7136419b2 Mon Sep 17 00:00:00 2001
From: Yury Gribov <address@hidden>
Date: Thu, 14 Apr 2016 16:41:06 +0300
Subject: [PATCH 3/3] Also visualize non-public functions that are (ab)used by
 other packages or readline examples.

---
 histlib.h   |  4 +++-
 rlprivate.h | 30 +++++++++++++++---------------
 rlshell.h   | 10 +++++-----
 3 files changed, 23 insertions(+), 21 deletions(-)

diff --git a/histlib.h b/histlib.h
index c938a10..2a60c6c 100644
--- a/histlib.h
+++ b/histlib.h
@@ -28,6 +28,8 @@
 #  include <strings.h>
 #endif /* !HAVE_STRING_H */
 
+#include "rlstdc.h"
+
 #if !defined (STREQ)
 #define STREQ(a, b)    (((a)[0] == (b)[0]) && (strcmp ((a), (b)) == 0))
 #define STREQN(a, b, n) (((n) == 0) ? (1) \
@@ -77,6 +79,6 @@ extern char *strchr ();
 #define HISTORY_OVERWRITE 1
 
 /* Some variable definitions shared across history source files. */
-extern int history_offset;
+READLINE_EXPORT int history_offset;
 
 #endif /* !_HISTLIB_H_ */
diff --git a/rlprivate.h b/rlprivate.h
index 14a370d..2d826ca 100644
--- a/rlprivate.h
+++ b/rlprivate.h
@@ -179,7 +179,7 @@ typedef void _rl_sigcleanup_func_t PARAMS((int, void *));
  *************************************************************************/
 
 /* complete.c */
-extern int rl_complete_with_tilde_expansion;
+READLINE_EXPORT int rl_complete_with_tilde_expansion;
 #if defined (VISIBLE_STATS)
 extern int rl_visible_stats;
 #endif /* VISIBLE_STATS */
@@ -263,17 +263,17 @@ extern void _rl_free_match_list PARAMS((char **));
 extern char *_rl_strip_prompt PARAMS((char *));
 extern void _rl_reset_prompt PARAMS((void));
 extern void _rl_move_cursor_relative PARAMS((int, const char *));
-extern void _rl_move_vert PARAMS((int));
+READLINE_EXPORT void _rl_move_vert PARAMS((int));
 extern void _rl_save_prompt PARAMS((void));
 extern void _rl_restore_prompt PARAMS((void));
 extern char *_rl_make_prompt_for_search PARAMS((int));
 extern void _rl_erase_at_end_of_line PARAMS((int));
 extern void _rl_clear_to_eol PARAMS((int));
-extern void _rl_clear_screen PARAMS((void));
+READLINE_EXPORT void _rl_clear_screen PARAMS((void));
 extern void _rl_update_final PARAMS((void));
 extern void _rl_redisplay_after_sigwinch PARAMS((void));
-extern void _rl_clean_up_for_exit PARAMS((void));
-extern void _rl_erase_entire_line PARAMS((void));
+READLINE_EXPORT void _rl_clean_up_for_exit PARAMS((void));
+READLINE_EXPORT void _rl_erase_entire_line PARAMS((void));
 extern int _rl_current_display_line PARAMS((void));
 
 /* input.c */
@@ -393,10 +393,10 @@ extern void _rl_audit_tty PARAMS((char *));
 
 extern int _rl_tropen PARAMS((void));
 
-extern int _rl_abort_internal PARAMS((void));
+READLINE_EXPORT int _rl_abort_internal PARAMS((void));
 extern int _rl_null_function PARAMS((int, int));
 extern char *_rl_strindex PARAMS((const char *, const char *));
-extern int _rl_qsort_string_compare PARAMS((char **, char **));
+READLINE_EXPORT int _rl_qsort_string_compare PARAMS((char **, char **));
 extern int (_rl_uppercase_p) PARAMS((int));
 extern int (_rl_lowercase_p) PARAMS((int));
 extern int (_rl_pure_alphabetic) PARAMS((int));
@@ -428,11 +428,11 @@ extern _rl_callback_generic_arg *_rl_callback_data;
 /* complete.c */
 extern int _rl_complete_show_all;
 extern int _rl_complete_show_unmodified;
-extern int _rl_complete_mark_directories;
-extern int _rl_complete_mark_symlink_dirs;
-extern int _rl_completion_prefix_display_length;
+READLINE_EXPORT int _rl_complete_mark_directories;
+READLINE_EXPORT int _rl_complete_mark_symlink_dirs;
+READLINE_EXPORT int _rl_completion_prefix_display_length;
 extern int _rl_completion_columns;
-extern int _rl_print_completions_horizontally;
+READLINE_EXPORT int _rl_print_completions_horizontally;
 extern int _rl_completion_case_fold;
 extern int _rl_completion_case_map;
 extern int _rl_match_hidden_files;
@@ -441,7 +441,7 @@ extern int _rl_skip_completed_text;
 extern int _rl_menu_complete_prefix_first;
 
 /* display.c */
-extern int _rl_vis_botlin;
+READLINE_EXPORT int _rl_vis_botlin;
 extern int _rl_last_c_pos;
 extern int _rl_suppress_redisplay;
 extern int _rl_want_redisplay;
@@ -464,9 +464,9 @@ extern _rl_arg_cxt _rl_argcxt;
 extern int _rl_utf8locale;
 
 /* readline.c */
-extern int _rl_echoing_p;
-extern int _rl_horizontal_scroll_mode;
-extern int _rl_mark_modified_lines;
+READLINE_EXPORT int _rl_echoing_p;
+READLINE_EXPORT int _rl_horizontal_scroll_mode;
+READLINE_EXPORT int _rl_mark_modified_lines;
 extern int _rl_bell_preference;
 extern int _rl_meta_flag;
 extern int _rl_convert_meta_chars_to_ascii;
diff --git a/rlshell.h b/rlshell.h
index 3e17d8b..be8e996 100644
--- a/rlshell.h
+++ b/rlshell.h
@@ -24,10 +24,10 @@
 
 #include "rlstdc.h"
 
-extern char *sh_single_quote PARAMS((char *));
-extern void sh_set_lines_and_columns PARAMS((int, int));
-extern char *sh_get_env_value PARAMS((const char *));
-extern char *sh_get_home_dir PARAMS((void));
-extern int sh_unset_nodelay_mode PARAMS((int));
+READLINE_EXPORT char *sh_single_quote PARAMS((char *));
+READLINE_EXPORT void sh_set_lines_and_columns PARAMS((int, int));
+READLINE_EXPORT char *sh_get_env_value PARAMS((const char *));
+READLINE_EXPORT char *sh_get_home_dir PARAMS((void));
+READLINE_EXPORT int sh_unset_nodelay_mode PARAMS((int));
 
 #endif /* _RL_SHELL_H_ */
-- 
1.9.1


reply via email to

[Prev in Thread] Current Thread [Next in Thread]