[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-readline] Fwd: [PATCH] readline: rltty.c: Declare ioctl() expli
From: |
Chen Gang |
Subject: |
Re: [Bug-readline] Fwd: [PATCH] readline: rltty.c: Declare ioctl() explicitly. |
Date: |
Sat, 25 Apr 2015 07:19:49 +0800 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 4/25/15 03:24, Chet Ramey wrote:
> On 4/21/15 3:38 PM, Chen Gang wrote:
>> On 4/20/15 08:06, Chet Ramey wrote:
>>> On 4/19/15 1:46 PM, Chen Gang wrote:
>>>>
>>>> Under Darwin, ioctl() is declared in "sys/ioctl.h", but except for some
>>>> special control commands, we do not want to include "sys/ioctl.h". So
>>>> declare it explicitly, the related warning:
>>>
>>> I suppose I could add that for Darwin/Mac OS X, but the supplied
>>> declaration is not correct for all systems (e.g., Solaris 10, HP-UX,
>>> AIX). That's why I don't declare it, and probably why autoconf doesn't
>>> have a test for it. Why not just include <sys/ioctl.h> there and see
>>> what happens?
>>>
>>
>> Just include <sys/ioctl.h> will be OK under Darwin:
>
> I'll try including <sys/ioctl.h> unconditionally (well, unconditionally if
> it exists).
>
It sounds OK to me.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed