[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-readline] [PATCH] readline/search.c: Remove useless parameter '
From: |
Joel Brobecker |
Subject: |
Re: [Bug-readline] [PATCH] readline/search.c: Remove useless parameter '0' for rl_message() |
Date: |
Mon, 22 Sep 2014 09:53:12 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
> >> The related warning under Darwin x86_64:
> >>
> >> gcc -c -DHAVE_CONFIG_H -I. -I../../binutils-gdb/readline
> >> -DRL_LIBRARY_VERSION='"6.2"' -g -O2 ../../binutils-gdb/readline/search.c
> >> ../../binutils-gdb/readline/search.c:213:24: warning: data argument not
> >> used by format string [-Wformat-extra-args]
> >> rl_message ("%s", p, 0);
> >> ~~~~ ^
> >> 1 warning generated.
> >>
> >>
> >> readline/ChangeLog.gdb:
> >>
> >> * search.c (_rl_nsearch_init): Remove useless parameter '0' for
> >> rl_message().
> >
> > Because readline is a separate project from binutils/GDB, we prefer
> > it if you would first submit the patch to the readline project first
> > (address@hidden, in Cc: of this email), get it accepted there.
>
> This bug was already fixed in bash 4.3.
I see! Sorry about the noise. For my penance, I pushed the patch in.
Do we need it for 7.8.1 as well?
--
Joel
- Re: [Bug-readline] [PATCH] readline/search.c: Remove useless parameter '0' for rl_message(), Joel Brobecker, 2014/09/22
- Re: [Bug-readline] [PATCH] readline/search.c: Remove useless parameter '0' for rl_message(), Andreas Schwab, 2014/09/22
- Re: [Bug-readline] [PATCH] readline/search.c: Remove useless parameter '0' for rl_message(),
Joel Brobecker <=
- Re: [Bug-readline] [PATCH] readline/search.c: Remove useless parameter '0' for rl_message(), Chen Gang, 2014/09/22
- Re: [Bug-readline] [PATCH] readline/search.c: Remove useless parameter '0' for rl_message(), Chet Ramey, 2014/09/22
- Re: [Bug-readline] [PATCH] readline/search.c: Remove useless parameter '0' for rl_message(), Chen Gang, 2014/09/22
- Re: [Bug-readline] [PATCH] readline/search.c: Remove useless parameter '0' for rl_message(), Joel Brobecker, 2014/09/23
- Re: [Bug-readline] [PATCH] readline/search.c: Remove useless parameter '0' for rl_message(), Chen Gang, 2014/09/23
Re: [Bug-readline] [PATCH] readline/search.c: Remove useless parameter '0' for rl_message(), Jan Kratochvil, 2014/09/22