[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-readline] [PATCH] readline/histfile.c: Check and retry write()
From: |
Chet Ramey |
Subject: |
Re: [Bug-readline] [PATCH] readline/histfile.c: Check and retry write() operation in history_truncate_file() |
Date: |
Sat, 21 Jun 2014 19:19:11 -0400 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 6/20/14, 10:25 PM, Chen Gang wrote:
>> There aren't really any plausible conditions under which write(2) returns
>> 0 instead of -1 when writing a non-zero number of bytes to a regular file.
>>
>
> Hmm... for me, what you said is acceptable. And the function comment need be
> changed:
>
> "Returns 0 on success, errno or -1 on failure"
history_truncate_file will never return -1.
> And since you will work for it next, is it still necessary to send patch v2
> for
> the temporary fix, at present?
I will take care of making those changes, thanks.
Chet
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRU address@hidden http://cnswww.cns.cwru.edu/~chet/
- [Bug-readline] [PATCH] readline/histfile.c: Check and retry write() operation in history_truncate_file(), Chen Gang, 2014/06/11
- Re: [Bug-readline] [PATCH] readline/histfile.c: Check and retry write() operation in history_truncate_file(), Chet Ramey, 2014/06/18
- Re: [Bug-readline] [PATCH] readline/histfile.c: Check and retry write() operation in history_truncate_file(), Chen Gang, 2014/06/18
- Re: [Bug-readline] [PATCH] readline/histfile.c: Check and retry write() operation in history_truncate_file(), Chen Gang, 2014/06/20
- Re: [Bug-readline] [PATCH] readline/histfile.c: Check and retry write() operation in history_truncate_file(), Chet Ramey, 2014/06/20
- Re: [Bug-readline] [PATCH] readline/histfile.c: Check and retry write() operation in history_truncate_file(), Chen Gang, 2014/06/20
- Re: [Bug-readline] [PATCH] readline/histfile.c: Check and retry write() operation in history_truncate_file(),
Chet Ramey <=
- Re: [Bug-readline] [PATCH] readline/histfile.c: Check and retry write() operation in history_truncate_file(), Chen Gang, 2014/06/21
- Re: [Bug-readline] [PATCH] readline/histfile.c: Check and retry write() operation in history_truncate_file(), Chet Ramey, 2014/06/23
- Re: [Bug-readline] [PATCH] readline/histfile.c: Check and retry write() operation in history_truncate_file(), Chen Gang, 2014/06/23
- Re: [Bug-readline] [PATCH] readline/histfile.c: Check and retry write() operation in history_truncate_file(), Chen Gang, 2014/06/25