Re: [Bug-readline] Set correct -compatibility_version in .dylib on Mac OS X

[Max Horn]

On 25.04.2014, at 20:45, Chet Ramey <address@hidden> wrote:

> Signed PGP part
> On 4/24/14, 7:45 AM, Max Horn wrote:
> > Ping?
> 
> I did not install this.  I may put in the cosmetic changes at a later time.
> The change to compatibility_version is not needed because patch 5 restores
> the old `Function'-style typedefs.

That is incorrect (and I tried to explain in my email why that is). 

First off, the change is necessary because new API was added -- it would have 
been necessary for 6.2, 6.1, etc., too, just nobody noticed.

Secondly, the removal of those typedefs is irrelevant, because that was only an 
API change, not an ABI change, so it doesn't affect the shared lib in any way.

Indeed, if the *ABI* would have been changed in a backward incompatible way 
(i.e. a function gets removed, or changes its semantics in an incompatible way) 
then the major version of the shared library should be changed from 6 to 7... 
but that is something that of course would already be covered by the existing 
build rules.


Cheers,
Max

signature.asc
Description: Message signed with OpenPGP using GPGMail