bug-readline
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-readline] Issue with colored-stats option with readline-6.3-rc1


From: Chet Ramey
Subject: Re: [Bug-readline] Issue with colored-stats option with readline-6.3-rc1 on Ubuntu 10.04.4LTS
Date: Wed, 11 Dec 2013 16:29:24 -0500
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20100101 Thunderbird/24.1.1

On 12/10/13 4:39 PM, Martin Wesdorp wrote:
> Hi,
> 
> I am doing some tests with the new colored-stats feature in
> readline-6.3-rc1 on an Ubuntu 10.04 LTS system. The new feature is enabled
> by adding "set colored-stats on" in the inputrc file. When readline() is
> then called from my app (sqsh) and initalizes, it throws an error:
> 
> readline: LS_COLORS: unrecognized prefix: hl
> readline: unparsable value for LS_COLORS environment variable

Thanks for the report.  The person who contributed this change took the
code from coreutils/ls.c, which changed `hl' to `mh' back in June, 2009.
It's been that way ever since.  I'm not sure why Ubuntu didn't change,
but I'm hesitant to do so.


> The reason that I get garbage data when I use filename completion after
> _rl_parse_colors() fails, is due to the fact that this function frees the
> _rl_color_ext_list of $LS_COLORS entries when it runs into an unknown
> entry, but does not disable the feature by setting _rl_colored_stats to 0.
> In file complete.c the function print_filename() still makes calls to
> colored_stat_start() and colored_stat_end() then and does not print the
> correct LEFT and RIGHT combination of colorcode control characters, I
> think. Wouldn't it be better by the way for _rl_parse_colors() to just
> ignore an unknown entry in $LS_COLORS instead of discarding all?

There are a few changes I can make in this area; thanks for pointing me in
the right direction.

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRU    address@hidden    http://cnswww.cns.cwru.edu/~chet/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]