[Bug-readline] Re: PATCH: readline/util.c, resource leak

[Jim Blandy]

Looks right to me.

address@hidden writes:
> 2007-07-31  Michael Snyder  <address@hidden>
>
>       * util.c (rl_tilde_expand): Resource leak.
>
> Index: util.c
> ===================================================================
> RCS file: /cvs/src/src/readline/util.c,v
> retrieving revision 1.6
> diff -p -r1.6 util.c
> *** util.c    5 May 2006 18:26:12 -0000       1.6
> --- util.c    1 Aug 2007 01:54:07 -0000
> *************** rl_tilde_expand (ignore, key)
> *** 185,190 ****
> --- 185,191 ----
>       {
>         homedir = tilde_expand ("~");
>         _rl_replace_text (homedir, start, end);
> +       free (homedir);
>         return (0);
>       }
>     else if (rl_line_buffer[start] != '~')
> *************** rl_tilde_expand (ignore, key)
> *** 215,220 ****
> --- 216,222 ----
>         free (temp);
>   
>         _rl_replace_text (homedir, start, end);
> +       free (homedir);
>       }
>   
>     return (0);