bug#17108: [PATCH 1/4] libparted: Check AlternateLBA against LBA-1

[Phillip Susi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 3/27/2014 11:00 AM, Brian C. Lane wrote:
> I haven't seen any evidence of that, and that isn't what's
> happening here.

Try running the test steps manually so you can see what is going on in
the middle before the test suite cleans it up.  Last time I did that,
the loop-file size went from 20m to 2g after running gpt-header-munge.
 That makes parted complain that the backup is in the wrong place.

> Ok, I'll check to make sure that isn't the case -- I thought the 
> location was updated when it was rewritten, but I'll double check.
> 
> But the basic problem here is that you are making calculations that
> are invalid, as revealed by the failing test. You cannot count on
> the AlternateLBA always being at the block after
> LastUsableLBA+Partition entries. This *may* be true, but it isn't
> guaranteed to be true.

How would it not be true?  The reason the calculation is that way
rather than last sector of the disk - 1 is because if you have a disk
that has been extended, then the backup is no longer at last sector -
1.  By changing it back to last sector - 1, you will be looking for it
in the wrong place after the disk has grown.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTNFCUAAoJEI5FoCIzSKrwqTkH/1ggCHfISIXSrCGaqYp9GX7V
09AEFulpwpV9ShJ04QbfBS7s9ShQQBJMds++2QyJpcXCVVG9TARynCAhZ9vSg/Ov
tNSDGlA/6DJQ+Bzs/mQNX3WyG0bEkrOlv9P+X+YBw+hT0f7ARRpsbSurnEHS565p
rVnNkjgvlZuIx/tVE75JZhB8aAHw3JVMjQ7W2XZ77gziMQmn+QB9Ox0/Qluxe8yv
hSk6lXFthvGZ0XHhl9zcyRjXBF7cFkfe6yISxSX3WEMYvx8MMbdeZms3k9XYRqWQ
C2DRBjVHX15T2vptL1uD4IhHUT4yi0P1hHe660i8tBhmRwp9uRbsmNgzHE9c0eg=
=bDhE
-----END PGP SIGNATURE-----