[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#15591: [PATCH] libparted: handle i18n gpt partition names correctly
From: |
Jim Meyering |
Subject: |
bug#15591: [PATCH] libparted: handle i18n gpt partition names correctly |
Date: |
Sun, 22 Dec 2013 18:45:31 -0800 |
On Sun, Dec 22, 2013 at 6:17 PM, Phillip Susi <address@hidden> wrote:
> +# check for expected output
> +dd if=$dev bs=1 skip=$(($sector_size_+$sector_size_+58)) count=10
> 2>/dev/null | od -An -tx1 > out || fail=1
> +echo \ 66 00 6f 00 6f 00 24 1d 00 00 >> exp
Thank you. That looks correct and is now more portable.
To avoid minor "reviewer surprise", I suggest to drop the use of
backslash-space and instead use single quotes around the
entire line, and use ">" rather than ">>", e.g.,
echo ' 66 00 6f 00 6f 00 24 1d 00 00' > exp
bug#15591: [PATCH] libparted: handle i18n gpt partition names correctly, Phillip Susi, 2013/12/20
bug#15591: [PATCH] libparted: handle i18n gpt partition names correctly, Jim Meyering, 2013/12/22