Re: [PATCH 00/11] various minor cleanup to the build system

[Stefano Lattarini]

On 08/30/2012 07:28 PM, Jim Meyering wrote:
> Stefano Lattarini wrote:
>> Several minor cleanups and modernization.  Some of them are good
>> on their own, some are motivated by the will to make a future
>> support of Automake-NG easier.
>>
>> -*-*-*-
>>
>> Stefano Lattarini (11):
>>   build: prefer $(AM_CPPFLAGS) over $(INCLUDES)
>>   build: don't list files with unknown suffix in _SOURCES
>>   build: prefer pattern rules over suffix rules
>>   build: enable subdir-objects Automake option globally
>>   tests: prefer AM_TESTS_ENVIRONMENT over TESTS_ENVIRONMENT
>>   tests: remove unused AM_TESTS_ENVIRONMENT entries
>>   build: require Automake >= 1.11.6
>>   maint: make Autoconf version requirement consistent
>>   maint: tighten per version requirement
>>   bootstrap: update to latest, from gnulib
>>   gitignore: reorder as forced by ./bootstrap
>>
>>  .gitignore                   |  20 ++--
>>  bootstrap                    | 267 
>> ++++++++++++++++++++++++++++---------------
>>  bootstrap.conf               |   6 +-
>>  configure.ac                 |   3 +-
>>  include/parted/Makefile.am   |   3 +-
>>  libparted/Makefile.am        |   2 +-
>>  libparted/fs/Makefile.am     |   4 +-
>>  libparted/labels/Makefile.am |   8 +-
>>  parted/Makefile.am           |   2 +-
>>  partprobe/Makefile.am        |   2 +-
>>  tests/Makefile.am            |   7 +-
>>  11 files changed, 200 insertions(+), 124 deletions(-)
> 
> Hi Stefano,
> 
> Thanks for doing all of that.
> So far I have no complaints.
> One nit is that I'd already updated to latest gnulib,
> bootstrap and init.sh (and made the few changes so
> that syntax-check still passes) but hadn't pushed.
> That means I'm omitting this patch of yours:
> 
>     bootstrap: update to latest, from gnulib
> 
> If you have any amendments to make before I push, please speak soon.
>
The only nit is that, if you have re-run ./bootstrap after updating
gnulib, you should already have the modifications to .gitignore
(just reordering of entries actually) in your tree, so the last patch
should become unnecessary.  OTOH, if that is not the case, we have a
strange bug in our hands, that is, ./bootstrap updates .gitignore for
me but not for you; in which case it is probably wiser to still drop
the last patch, until we understand what is going on.

> BTW, I'll let the 1.11.6 stand here, even though for coreutils
> I backed it down to 1.11.2.  We'll see if anyone complains.

Thanks,
  Stefano