[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 02/11] build: don't list files with unknown suffix in _SOURCES
From: |
Stefano Lattarini |
Subject: |
[PATCH 02/11] build: don't list files with unknown suffix in _SOURCES |
Date: |
Thu, 30 Aug 2012 18:53:14 +0200 |
While this works with mainline Automake (which blindly treats source
files with an unknown extension as if they were header files), it is
undocumented (albeit admittedly unlikely to change). Moreover, it no
longer works with Automake-NG (and that's by design), so the use of
such feature would make a port to Automake-NG more difficult.
* libparted/labels/Makefile.am (liblabels_la_SOURCES): ... don't
list 'pt-limit.gperf' here; rather ...
(EXTRA_DIST): ... list 'pt-limit.c' and 'pt-limit.gperf' here.
(EXTRA_DIST, BUILT_SOURCES): Enhance few comments.
Copyright-paperwork-exempt: yes
---
libparted/labels/Makefile.am | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libparted/labels/Makefile.am b/libparted/labels/Makefile.am
index ec8abeb..f4e4d27 100644
--- a/libparted/labels/Makefile.am
+++ b/libparted/labels/Makefile.am
@@ -39,10 +39,11 @@ liblabels_la_LIBADD = $(OS_LIBS) $(INTLLIBS)
AM_CPPFLAGS = $(partedincludedir) $(INTLINCS)
+# Included by 'pt-tools.c', so needs to be built early.
BUILT_SOURCES = pt-limit.c
MAINTAINERCLEANFILES = $(BUILT_SOURCES)
-liblabels_la_SOURCES += pt-limit.gperf
-EXTRA_DIST = $(BUILT_SOURCES)
+# DOn't add this to '_SOURCES', because it's not to be compiled!
+EXTRA_DIST= pt-limit.c
GPERF = gperf
GPERF_OPTIONS = \
@@ -55,3 +56,4 @@ pt-limit.c: pt-limit.gperf
> address@hidden
chmod a-w address@hidden
mv address@hidden $@
+EXTRA_DIST += pt-limit.gperf
- [PATCH 00/11] various minor cleanup to the build system, Stefano Lattarini, 2012/08/30
- [PATCH 01/11] build: prefer $(AM_CPPFLAGS) over $(INCLUDES), Stefano Lattarini, 2012/08/30
- [PATCH 02/11] build: don't list files with unknown suffix in _SOURCES,
Stefano Lattarini <=
- [PATCH 03/11] build: prefer pattern rules over suffix rules, Stefano Lattarini, 2012/08/30
- [PATCH 05/11] tests: prefer AM_TESTS_ENVIRONMENT over TESTS_ENVIRONMENT, Stefano Lattarini, 2012/08/30
- [PATCH 07/11] build: require Automake >= 1.11.6, Stefano Lattarini, 2012/08/30
- [PATCH 06/11] tests: remove unused AM_TESTS_ENVIRONMENT entries, Stefano Lattarini, 2012/08/30
- [PATCH 09/11] maint: tighten per version requirement, Stefano Lattarini, 2012/08/30
- [PATCH 04/11] build: enable subdir-objects Automake option globally, Stefano Lattarini, 2012/08/30
- [PATCH 08/11] maint: make Autoconf version requirement consistent, Stefano Lattarini, 2012/08/30
- [PATCH 11/11] gitignore: reorder as forced by ./bootstrap, Stefano Lattarini, 2012/08/30
- [PATCH 10/11] bootstrap: update to latest, from gnulib, Stefano Lattarini, 2012/08/30
- Re: [PATCH 00/11] various minor cleanup to the build system, Jim Meyering, 2012/08/30