bug-ncurses
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 12/45] ncurses/tinfo/lib_raw.c: Drop comments.


From: G. Branden Robinson
Subject: [PATCH 12/45] ncurses/tinfo/lib_raw.c: Drop comments.
Date: Sat, 25 May 2024 12:39:51 -0500

It is now possible to resolve these long-open questions about System V
curses behavior.

System V curses always manipulated the NOFLSH termio flag when
`intrflush()` (new to SVr2) and, later, `{no,}qiflush()` was called.

SVr2 (for NS32000):

src/lib/libcurses/screen/intrflush.c:23:          (cur_term->Nttyb).c_lflag &= 
~NOFLSH;
src/lib/libcurses/screen/intrflush.c:25:          (cur_term->Nttyb).c_lflag |= 
NOFLSH;

SVr2 (for VAX):

src/lib/libcurses/screen/intrflush.c:12:             (cur_term->Nttyb).c_lflag 
&= ~NOFLSH;
src/lib/libcurses/screen/intrflush.c:14:             (cur_term->Nttyb).c_lflag 
|= NOFLSH;

SVr3.01:

usr/src/lib/libcurses/screen/intrflush.c:23:         PROGTTY.c_lflag &= ~NOFLSH;
usr/src/lib/libcurses/screen/intrflush.c:25:         PROGTTY.c_lflag |= NOFLSH;

For SVr3.1, `intrflush()` became a wrapper for `qiflush()` or
`noqiflush()`, depending on the value of its Boolean argument.

SVr3.1:

usr/src/lib/libcurses/screen/setqiflush.c:21: cur_term->Nttyb.c_lflag &= 
~NOFLSH;
usr/src/lib/libcurses/screen/setqiflush.c:23: cur_term->Nttyb.c_lflag |= NOFLSH;

SVr4 renamed its curses implmentation "(lib)xcurses" and restored BSD
curses as "libcurses", losing all of the foregoing functions.

SVr4:

lib/xlibcurses/screen/setqiflush.c:23:      cur_term->Nttyb.c_lflag &= ~NOFLSH;
lib/xlibcurses/screen/setqiflush.c:25:      cur_term->Nttyb.c_lflag |= NOFLSH;
---
 ncurses/tinfo/lib_raw.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/ncurses/tinfo/lib_raw.c b/ncurses/tinfo/lib_raw.c
index fda6deada..2d2b87ba0 100644
--- a/ncurses/tinfo/lib_raw.c
+++ b/ncurses/tinfo/lib_raw.c
@@ -179,10 +179,6 @@ cbreak(void)
 }
 #endif
 
-/*
- * Note:
- * this implementation may be wrong.  See the comment under intrflush().
- */
 NCURSES_EXPORT(void)
 NCURSES_SP_NAME(qiflush) (NCURSES_SP_DCL0)
 {
@@ -349,11 +345,7 @@ noqiflush(void)
 #endif
 
 /*
- * This call does the same thing as the qiflush()/noqiflush() pair.  We know
- * for certain that SVr3 intrflush() tweaks the NOFLSH bit; on the other hand,
- * the match (in the SVr4 man pages) between the language describing NOFLSH in
- * termio(7) and the language describing qiflush()/noqiflush() in
- * curs_inopts(3x) is too exact to be coincidence.
+ * This call does the same thing as the qiflush()/noqiflush() pair.
  */
 NCURSES_EXPORT(int)
 NCURSES_SP_NAME(intrflush) (NCURSES_SP_DCLx WINDOW *win GCC_UNUSED, bool flag)
-- 
2.30.2

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]