Re: Still problems with setting window title in Vim

[Thomas Dickey]

On Mon, Apr 17, 2023 at 05:25:57PM -0400, Thomas Dickey wrote:
> On Mon, Apr 17, 2023 at 06:31:52PM +0200, Sven Joachim wrote:
> > In the latest patchlevel (20230415), starting vim with
> > TERM=xterm-256color and typing the command ":set title" fails to set the
> > window title in xterm and gnome-terminal, but rather beeps and prints
> > the new title into the status area, as described in Gentoo bug
> > 904263[1], although the latest message there claims that it should have
> > been fixed.  Am I missing something?
> 
> no - I did.  See
> 
> https://bugzilla.suse.com/show_bug.cgi?id=1210485

The issue was passing a no-argument string to tgoto,
which wasn't in the terminal description.

I've done this for the next patch:

--- ncurses-6.4-20230415+/include/nc_tparm.h    2020-05-27 23:33:31.000000000 
+0000
+++ ncurses-6.4-20230422/include/nc_tparm.h     2023-04-16 17:57:28.000000000 
+0000
@@ -78,6 +78,7 @@
 #endif
 
 #ifdef NCURSES_INTERNALS
+#define TIPARM_0(s) _nc_tiparm(0,s)
 #define TIPARM_1(s,a) _nc_tiparm(1,s,a)
 #define TIPARM_2(s,a,b) _nc_tiparm(2,s,a,b)
 #define TIPARM_3(s,a,b,c) _nc_tiparm(3,s,a,b,c)
--- ncurses-6.4-20230415+/ncurses/tinfo/lib_tgoto.c     2023-04-08 
13:48:58.000000000 +0000
+++ ncurses-6.4-20230422/ncurses/tinfo/lib_tgoto.c      2023-04-16 
17:19:40.000000000 +0000
@@ -214,7 +214,9 @@
         * using tgoto().  The internal _nc_tiparm() function returns a NULL
         * for that case; retry for the single-parameter case.
         */
-       result = TIPARM_1(string, y);
+       if ((result = TIPARM_1(string, y)) == NULL) {
+           result = TIPARM_0(string);
+       }
     }
     returnPtr(result);
 }

(this sort of fix is in-scope -- some, as in OpenRC -- won't be)

-- 
Thomas E. Dickey <dickey@invisible-island.net>
https://invisible-island.net

signature.asc
Description: PGP signature