Re: Crash when restoring screen

[Thomas Dickey]

On Tue, Oct 19, 2021 at 10:11:38PM +0000, Frank Tkalcevic wrote:
> > (I can reproduce this, have a fix)
> 
> Thank you, that was fast.

I've been working to prepare a new release, so I had to see whether
this would go in "now" or wait a couple of weeks.  (I'd try to respond
quickly anyway, since it crashed).
 
> >> it displays rubbish in the extended area then crashes.  It works fine
> >> on Solaris/curses.  I’m using xterm and teraterm.
> >
> >"fine" is relative: Solaris curses won't detect the screen size-change, so 
> >it'll continue using the same dimensions.  In some cases (particularly if 
> >>shrinking the screen), you'll get odd repainting due to wrapping.
> >ncurses won't wrap.
> 
> Is the fix to return an error if the sizes don't match, or to try and squeeze 
> in what can?

My fix uses wresize, which will fill with blanks where the window size
increases, and truncate when shrinking.

If you're using subwindows, that also shrinks them, but making a
layout look nice really requires having the application see that
getch returned KEY_RESIZE and then redrawing the screen as needed.

(the dialog program does this).
 
> Our work around at the moment is to prevent the users from resizing the
> terminal, but they can re-enable it if they are crafty.

-- 
Thomas E. Dickey <dickey@invisible-island.net>
https://invisible-island.net
ftp://ftp.invisible-island.net

signature.asc
Description: PGP signature