Re: _nc_env_access also denies non-root users from reading env vars

[Arnavion]

On Sat, Aug 28, 2021 at 12:33 AM Arnavion <me@arnavion.dev> wrote:
> That is, it should've been:
>
> +    } else if ((getuid() == ROOT_UID) || (geteuid() == ROOT_UID)) {
> +       result = FALSE;
> +    }
>

Thomas, I see patch 20210828 has:

-    } else if ((getuid() != ROOT_UID) && (geteuid() != ROOT_UID)) {
+    } else if ((getuid() == ROOT_UID) && (geteuid() == ROOT_UID)) {
        result = FALSE;

Did you mean to have that be && and not || ? The code before 20210626
would've disallowed suid binaries from reading the env vars.
The code after 20210828 will allow them.

Thanks,
Arnav Singh