[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-ncurses] Optical change in dialog passwordbox
|
From: |
Dr. Werner Fink |
|
Subject: |
Re: [bug-ncurses] Optical change in dialog passwordbox |
|
Date: |
Fri, 21 May 2021 10:05:04 +0200 |
On 2021/05/20 15:58:09 +0200, Dr. Werner Fink wrote:
> Hi,
>
> in older versions of dialog the command
>
> dialog --insecure --passwordbox "Enter root password" 0 0
>
> show
>
> +----------------------------+
> | Enter root password |
> | +------------------------+ |
> | | | |
> | +------------------------+ |
> +----------------------------+
> | < OK > <Abbrechen> |
> +----------------------------+
>
> with current dialog:
>
> +----------------------------+
> | Enter root password |
> | +------------------------+ |
> | | | |
> | +------------------------+ |
> | |
> | |
> +----------------------------+
> | < OK > <Cancel> |
> +----------------------------+
>
> and this extra empty line cause a soft failur here in out QA test suite
>
> Werner
>
This seems to restore the old layout
--- inputbox.c
+++ inputbox.c 2021-05-21 08:00:13.324086975 +0000
@@ -39,7 +39,7 @@
#define BTN_HIGH 1
#define HDR_HIGH 1
-#define MIN_HIGH (HDR_HIGH + (MARGIN * 2 + 1) + (BTN_HIGH + MARGIN * 2))
+#define MIN_HIGH (HDR_HIGH + (MARGIN + 1) + (BTN_HIGH + MARGIN))
#define MIN_WIDE 26
/*
I'd like to ask what the rational is for the doubling of the margins?
Werner
--
"Having a smoking section in a restaurant is like having
a peeing section in a swimming pool." -- Edward Burr
signature.asc
Description: PGP signature