[PATCH] setupterm regression in 6.2_p20200906

[Sören Tempel]

Hi,

I am not subscribed to the list, please CC me.

I believe a regression was introduced in setupterm with ncurses
6.2_p20200906. The emptyness check of the TERM environment variable is
incorrect. A patch is attached. I would also suggest renaming the
CHECK_TERM_ENV macro to a name which indicates the return value, e.g.
IS_VALID_TERM_ENV.

I ran into this regression this morning with `mosh-client -c` which
errored out with `TERM environment variable not set.`:

        664         if (tname == 0) {
        (gdb) n
        665             tname = getenv("TERM");
        (gdb) n
        670             if (!CHECK_TERM_ENV(tname, NO_TERMINAL)) {
        (gdb) p tname
        $1 = 0x7fffffffecdb "rxvt-unicode-256color"
        (gdb) n
        672                 ret_error0(TGETENT_ERR, "TERM environment variable 
not set.\n");

Greetings,
Sören

fix-setupterm.patch
Description: Text document