Re: [PATCH] Don't prepend implementation with EXPORT (declaration has it)

[Thomas Dickey]

On Tue, Aug 25, 2020 at 11:31:49PM +0200, anonymous.maarten@gmail.com wrote:
> From: Anonymous Maarten <anonymous.maarten@gmail.com>
> 
> Hello,
> 
> I am currently trying to add ncurses as the backend for the curses
> module of python.
> See:
> - https://bugs.python.org/issue41630
> - https://github.com/python/cpython/pull/21950
> 
> While building the ARM ncurses libraries, I had to apply the patch below.

odd - why is _nc_doalloc different from the other functions?
 
> The only other problem I am having with cross building using MSVC,
> is that vcvars only allow setting one target architecture.

It would be slower, but having a shell-script for
the build/target architectures could solve that problem.

> By not having access to a compiler for the build architecture,
> `ncurses/make_hash.exe` and `ncurses/make_keys.exe` are built for the
> ARM architecture and cannot be used to generate sources.
> 
> As a workaround, I copy the files from a native ncurses build tree.
> 
> Best regards
> Maarten
> 
> ---
>  ncurses/tinfo/doalloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ncurses/tinfo/doalloc.c b/ncurses/tinfo/doalloc.c
> index f0c8141a..eeb4359e 100644
> --- a/ncurses/tinfo/doalloc.c
> +++ b/ncurses/tinfo/doalloc.c
> @@ -42,7 +42,7 @@
>  
>  MODULE_ID("$Id: doalloc.c,v 1.12 2020/02/02 23:34:34 tom Exp $")
>  
> -NCURSES_EXPORT(void *)
> +void *
>  _nc_doalloc(void *oldp, size_t amount)
>  {
>      void *newp;
> -- 
> 2.21.3
> 
> 

-- 
Thomas E. Dickey <dickey@invisible-island.net>
https://invisible-island.net
ftp://ftp.invisible-island.net

signature.asc
Description: PGP signature