Re: [PATCH] Update Alacritty terminfo

[Thomas Dickey]

On Tue, Dec 31, 2019 at 05:00:04PM +0100, Christian Dürr wrote:
> This updates the Alacritty terminfo to the latest revision available in its
> repository.

I've been busy, but took a quick look last night.

Offhand (I haven't investigated the key-modifiers),
the only change needed appears to be the overlooked "ech" feature.
 
> Since there have been some changes made to the xterm base, it does not use the
> xterm terminfo anymore. However it would probably be possible to extract some 
> of
> the things if it's desirable to minimize size.
> 
> I've also taken the liberty to update some of the notes made, that I do not
> believe are accurate anymore. The multiple modifiers was actively patched. I

I'll have to retest that (but I'll retest from a package, _not_
from development source).  The only package that I'm aware of is
on Arch Linux; last week I worked around one of those periodic
issues with Arch where their upgrade needed a lot of tweaks to go.

> wasn't aware of issues with cursor position after leaving the alt screen, but
> comparing it to XTerm does not show any difference to me.
> 
> If there's any inaccurate statements or improvements to be made, please let me
> know and I can fix things upstream in Alacritty.

The changes to the comments aren't useful/accurate.  The alacritty terminfo
entry isn't a _derived_ work since it doesn't introduce new/original features.

(ncurses terminal database will use building-blocks to make the relationships
clear, whether or not your source uses those).

-- 
Thomas E. Dickey <address@hidden>
https://invisible-island.net
ftp://ftp.invisible-island.net

signature.asc
Description: PGP signature