Re: Drop erroneous spaces from tmux entry.

[C Anthony Risinger]

On Thu, May 17, 2018 at 3:21 AM, Thomas Dickey <address@hidden> wrote:

On Thu, May 17, 2018 at 12:02:09AM -0500, C Anthony Risinger wrote:
> Drop the repeated `\s` in `tmux`'s `sgr` capability. It doesn't work for me
> when they're present. I simply copied the `sgr` entry from `iterm2`
> verbatim (identical aside from `iterm2`'s better handling of
> standout/reverse).

I trimmed off the spurious whitespace...

Is there a reason not to use the handling from iTerm2 (and maybe others)? They are functionally the same:

$ diff -u <(infocmp -1gaf iterm2 | sed -E -n '/(sgr)=/,/\,$/p') <(infocmp -1gaf tmux | sed -E -n '/(sgr)=/,/\,$/p')

--- /dev/fd/63 2018-05-17 07:59:06.000000000 -0500

+++ /dev/fd/62 2018-05-17 07:59:06.000000000 -0500

@@ -4,16 +4,20 @@

  %t;1

  %;

  %?

+ %p1

+ %t;7

+ %;

+ %?

  %p2

  %t;4

  %;

  %?

- %p1%p3%|

+ %p3

  %t;7

  %;

  %?

  %p4

- %t;5

+ %t;\s\s\s\s\s\s\s\s\s\s\s\s5

  %;

  %?

  %p5

AFAICT it does work fine when `;7` gets emitted twice (once for standout, once for reverse), but the `%p1%p3%|`-based version exists today and is already battle-tested.

> Is there a place to submit PRs? Or something similarly low barrier?

https://invisible-island.net/ncurses/ncurses.faq.html#report_bugs

this is it.

Oh for sure. We all love ourselves a good hearty ML! The problem I'm trying to surface is the unusually high barrier of entry (for 2018, the bonafide future):

* How to track progress of a specific request? (ie. PR)
* How to build the latest code? (FAQ/README/etc make no mention of a canonical repo)
* How to credit people for changes? (This isn't super important, but I am a SWE after all!)
* How to ... ?

The FAQ says things I've either not heard for quite awhile or guarantee you alone must endure 100% the workload (we can help, promise!):

* I get about half of my bug reports via the ncurses mailing list, some via bug-tracking systems, and the others via direct email.
* When sending patches, specify the version of ncurses that you are patching.
* Sorry. This is a hobby. There's a large backlog.
* Occasionally I have patches (including my own) which cannot pass immediate review; these constitute most of my backlog.
* I issue patches on Saturdays,

Ncurses is important. Git, and established tooling with solid web interfaces, effect measurable improvements on the developer experience. It'd be super to wire up things like automated tests, etc, ultimately lowering and/or delegating your own responsibilities to machines and others.

A good example is this very change I am seeking now. Once discovered, it was fixed instantly. With a presence on GitHub (or BitBucket, or even a free/simple/basic location), I would've made the update on-the-spot and moved on with $DAYJOB. Alas, now you'll be hearing from me more than anyone would willfully endure :-)

No worries, and not really a complaint per se, more of a gentle nudge to achieve greater visibility from folks like myself (very active... and over-committed)!

Thanks,