Re: Color support in NCursesMenu::post()

[Thomas Dickey]

On Sun, Jan 07, 2018 at 07:47:13PM +0100, Federico Di Pierro wrote:
> Il 06/01/2018 14:09, Thomas Dickey ha scritto:
> >On Sat, Jan 06, 2018 at 12:10:11PM +0100, address@hidden wrote:
> >>Hi all,
> >>
> >>the original patches are attached.
> >
> >thanks - but:
> >
> >I'll consider this for ncurses 6.2 (my comment from 2015 was not addressed,
> >and it is not useful for wide-characters).
> >
> >Barring bug fixes, I will make no changes to the ABI before releasing 6.1
> >
> 
> I saw your comment on that thread; care to explain me better what were the
> issues with those patches?

offhand:

a) the patches aren't using unified diff.  There's not even a context diff.

b) there's no support for extended colors (i.e., the wide-character library)

c) there's no documentation

d) there's no sample code which uses it.

Given all of that, I can of course see the intent of the change, but
most of the work isn't done by those patches.
 
> I still think that adding a new PrintItem virtual function to let user
> override it, it's a better idea as it gives much more options though.

in C++ binding, that's (again) another bit of code to write...
 
> By the way, it would really nice to have this in 6.2.
> 
> Thanks for your time!
> -- 
> Federico

-- 
Thomas E. Dickey <address@hidden>
https://invisible-island.net
ftp://ftp.invisible-island.net

signature.asc
Description: Digital signature