[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Patch] Forms: Fix _nc_Synchronize_Attributes for O_PUBLIC
From: |
Leon Winter |
Subject: |
[Patch] Forms: Fix _nc_Synchronize_Attributes for O_PUBLIC |
Date: |
Wed, 21 Dec 2016 17:06:56 +0100 |
User-agent: |
NeoMutt/20161126 (1.7.1) |
Hi,
File: form/frm_driver.c
Function: _nc_Synchronize_Attributes
Line: 1274
http://ncurses.scripts.mit.edu/?p=ncurses.git;a=blob;f=form/frm_driver.c;h=87c1188e327686e582f4978a5caf4b3b5bf70e3b;hb=c885a3fdd089f784f17dd2e9c03d8eb774072dc9#l1278
when using a field with the attribute O_PUBLIC the function
_nc_Synchronize_Attributes makes a bad call to copywin. According to the man
page and all other uses of the function copywin the parameters dmaxrow and
dmaxcol must be maximum coordinates of the box and therefore be bigger than the
starting coordinates dminrow and dmincol. One therefore normally adds the
starting coordinates on top of the desired width and length. However in the
code mentioned this was not done. According to git this bug is in place at least
since 1997 (the git above does not account prior to that commit of '97).
See patch attached.
Thanks,
Leon
ncurses-sync-fix.patch
Description: Text Data
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Patch] Forms: Fix _nc_Synchronize_Attributes for O_PUBLIC,
Leon Winter <=