Re: Build failure with GCC 5.2.1

[Corey Minyard]

On 01/13/2016 08:06 PM, Thomas Dickey wrote:
> On Wed, Jan 13, 2016 at 09:30:48AM -0600, Corey Minyard wrote:
> > In reference to:
> > http://lists.gnu.org/archive/html/bug-ncurses/2015-08/msg00009.html
> >
> > I'm seeing the same issue, and I didn't see any resolution on the
> > mailing list, and ncurses has no publicly available repository that
> > I can find.
> But the followup messages on that thread show that I addressed the
> problem, and there has been no activity on that for several months.
>
> http://lists.gnu.org/archive/html/bug-ncurses/2015-08/msg00014.html

Ok, it wasn't clear to me that was the fix for this issue.  I shouldn't 
have missed that.  Thanks.

> > I fixed the problem with the following patch, though I'm not exactly
> > sure why this fixes the problem.  But the forward definition of
> > mouse_trafo is kind of pointless here, mouse_trafo is #define-ed to
> > call wmouse_trafo() about 12 lines down.  So the function could
> > never be called.
> It can be called easily - see the curses.h header file:
>
>         #ifndef NCURSES_NOMACROS

If you are expecting this behaviour, you should probably check the 
curses.h file:


extern NCURSES_EXPORT(bool)    has_mouse(void);
extern NCURSES_EXPORT(int)     getmouse (MEVENT *);
extern NCURSES_EXPORT(int)     ungetmouse (MEVENT *);
extern NCURSES_EXPORT(mmask_t) mousemask (mmask_t, mmask_t *);
extern NCURSES_EXPORT(bool)    wenclose (const WINDOW *, int, int);
extern NCURSES_EXPORT(int)     mouseinterval (int);
extern NCURSES_EXPORT(bool)    wmouse_trafo (const WINDOW*, int*, int*, 
bool);
extern NCURSES_EXPORT(bool)    mouse_trafo (int*, int*, 
bool);              /* generated */

#if NCURSES_SP_FUNCS
extern NCURSES_EXPORT(bool)    NCURSES_SP_NAME(has_mouse) (SCREEN*);
extern NCURSES_EXPORT(int)     NCURSES_SP_NAME(getmouse) (SCREEN*, 
MEVENT *);
extern NCURSES_EXPORT(int)     NCURSES_SP_NAME(ungetmouse) 
(SCREEN*,MEVENT *);
extern NCURSES_EXPORT(mmask_t) NCURSES_SP_NAME(mousemask) (SCREEN*, 
mmask_t, mmask_t *);
extern NCURSES_EXPORT(int)     NCURSES_SP_NAME(mouseinterval) (SCREEN*, 
int);
#endif

#define mouse_trafo(y,x,to_screen) wmouse_trafo(stdscr,y,x,to_screen)


The define for mouse_trafo is not inside

#ifndef NCURSES_NOMACROS


I checked with all the patchsets applied.

Thanks, again,

-corey

> > Thanks,
> >
> > -corey
> >
> > --- a/include/curses.tail.old   2016-01-05 19:55:06.267420940 -0600
> > +++ b/include/curses.tail       2016-01-05 19:55:14.575557130 -0600
> > @@ -101,7 +101,6 @@
> >   extern NCURSES_EXPORT(bool)    wenclose (const WINDOW *, int, int);
> >   extern NCURSES_EXPORT(int)     mouseinterval (int);
> >   extern NCURSES_EXPORT(bool)    wmouse_trafo (const WINDOW*, int*,
> > int*, bool);
> > -extern NCURSES_EXPORT(bool)    mouse_trafo (int*, int*, bool);
> > /* generated */
> >
> >   #if NCURSES_SP_FUNCS
> >   extern NCURSES_EXPORT(bool)    NCURSES_SP_NAME(has_mouse) (SCREEN*);