Re: unset ACTUAL_LDFLAGS in Ada binding configuration

[Thomas Dickey]

On Mon, Sep 14, 2015 at 07:43:11PM +0200, Nicolas Boulenguez wrote:
> Hello.
> 
> When compiling AdaCurses-20150808 on Debian unstable, "./configure"
> warns that the @ADAGEN_LDFLAGS@ substitution is undefined.  then
> "make" fails, complaining that file @ADAGEN_LDFLAGS@ does not exist.
> 
> gen/Makefile.in contains:
>  89: ACTUAL_LDFLAGS  = @ADAGEN_LDFLAGS@
> 163: @ECHO_LD@ $(LINK) $(CFLAGS_NORMAL) gen.o $(ACTUAL_LDFLAGS) -o $@
> and grep finds no other occurrence of ADAGEN_LDFLAGS or
> ACTUAL_LDFLAGS.
> 
> However, I can build the package by enforcing
> "ACTUAL_LDFLAGS=$LDFLAGS" on the "make" command line.

Actually..., grep shows me this - for "ADAGEN_LDFLAGS":

./configure.in:2179:    ADAGEN_LDFLAGS='$(CROSS_LDFLAGS)'
./configure.in:2181:    ADAGEN_LDFLAGS='$(NATIVE_LDFLAGS)'
./configure.in:2183:AC_SUBST(ADAGEN_LDFLAGS)
./Ada95/gen/Makefile.in:89:ACTUAL_LDFLAGS       = @ADAGEN_LDFLAGS@
./configure:22350:      ADAGEN_LDFLAGS='$(CROSS_LDFLAGS)'
./configure:22352:      ADAGEN_LDFLAGS='$(NATIVE_LDFLAGS)'
./configure:23089:s,@ADAGEN_LDFLAGS@,$ADAGEN_LDFLAGS,;t t

and this for the derived ACTUAL_LDFLAGS:

./Ada95/gen/Makefile.in:89:ACTUAL_LDFLAGS       = @ADAGEN_LDFLAGS@
./Ada95/gen/Makefile.in:163:    @ECHO_LD@ $(LINK) $(CFLAGS_NORMAL) gen.o 
$(ACTUAL_LDFLAGS) -o $@

...so what I overlooked is adding this chunk to Ada95/configure.in :

if test "x$cross_compiling" = xyes ; then
        ADAGEN_LDFLAGS='$(CROSS_LDFLAGS)'
else
        ADAGEN_LDFLAGS='$(NATIVE_LDFLAGS)'
fi
AC_SUBST(ADAGEN_LDFLAGS)

Looking at the changes, that was a build-fix where I didn't notice
the extra place to amend:

20150606 pre-release
        + fix a regression in Ada95/gen/Makefile.in, to handle special case of
          Cygwin, which uses the broken-linker feature.

-- 
Thomas E. Dickey <address@hidden>
http://invisible-island.net
ftp://invisible-island.net

signature.asc
Description: Digital signature