[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: ncurses-5.9-20120622.patch.gz
From: |
Thomas Dickey |
Subject: |
Re: ncurses-5.9-20120622.patch.gz |
Date: |
Sun, 24 Jun 2012 20:41:19 -0400 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Sat, Jun 23, 2012 at 08:53:01AM +0200, Sven Joachim wrote:
> On 2012-06-23 02:41 +0200, Thomas Dickey wrote:
>
> > + fix caching of environment variables in database-iterator (patch by
> > Philippe Troin, Redhat #831366).
>
> Is the following code in update_getenv() intentional? Calling
> getenv(name) twice looks rather redundant.
no - it's overlooked from my cleanup of the patch (thanks)
> ,----
> | char *value = getenv(name);
> |
> | if ((value = getenv(name)) == 0 || (value = strdup(value)) == 0) {
> `----
>
> Cheers,
> Sven
--
Thomas E. Dickey <address@hidden>
http://invisible-island.net
ftp://invisible-island.net
signature.asc
Description: Digital signature