Re: tack: --enable-warnings configure flag doesn't actually work

[Thomas Dickey]

On Thu, Mar 01, 2012 at 10:23:43PM -0500, Samuel Bronson wrote:
> I feel a little silly not to have noticed this sooner, but it occurred
> to me today as I was working on packaging the latest snapshot that the
> warning flags that tack's configure script detects when given the
> --enable-warnings flag don't actually get passed to the compiler.
> 
> Searching through config.status reveals that it is prepared to
> substitute them in wherever @EXTRA_CFLAGS@ appears in Makefile.in, but
> Makefile.in doesn't actually contain that anywhere.

I see (overlooked that...)
 
> And if you do add it in, you get a whole pile of warnings about
> undefined preprocessor macros...

I can fix that (have just made a first draft of that, will check the
various compilers that care about this).
 
> (Also, configure.in looks really strange now; it's best not to use TAB
> for any visual effect besides "some indentation at the beginning of
> the line" or "skip to the next 8th column".)

yes (the same applies to ncurses-examples's configure.in)

thanks

-- 
Thomas E. Dickey <address@hidden>
http://invisible-island.net
ftp://invisible-island.net

signature.asc
Description: Digital signature