bug-ncurses
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch-2.5.[67] causes latest ncurses rollup patch to fail


From: Paul Eggert
Subject: Re: patch-2.5.[67] causes latest ncurses rollup patch to fail
Date: Sun, 2 Jun 2002 22:56:22 -0700 (PDT)

> From: Mike Castle <address@hidden>
> Date: Sun, 2 Jun 2002 03:24:30 -0700
> 
> I'm sending this to both bug-ncurses and bug-patch.  Is there an archive
> for bug-patch?

I'm afraid not.  I suppose there should be.

> Now I figure patch shouldn't segfault, no matter what the problem is.

Yes, that's correct.  Thanks for the bug report.  The bug should
be fixed in patch 2.5.8, which you can get from:

ftp://alpha.gnu.org/gnu/patch/patch-2.5.8.tar.gz

The relevant patch is:

2002-06-02  Paul Eggert  <address@hidden>

        * inp.c (report_revision): Don't modify 'revision', since
        it gets freed later.  Bug reported by Mike Castle.

--- inp.c       2002/05/28 07:12:03     1.23
+++ inp.c       2002/06/03 05:35:40     1.24
@@ -1,6 +1,6 @@
 /* inputting files to be patched */
 
-/* $Id: inp.c,v 1.23 2002/05/28 07:12:03 eggert Exp $ */
+/* $Id: inp.c,v 1.24 2002/06/03 05:35:40 eggert Exp $ */
 
 /* Copyright (C) 1986, 1988 Larry Wall
    Copyright (C) 1991, 1992, 1993, 1997, 1998, 1999, 2002 Free Software
@@ -105,26 +105,26 @@ scan_input (char *filename)
 static void
 report_revision (int found_revision)
 {
-  revision = quotearg (revision);
+  char const *rev = quotearg (revision);
 
   if (found_revision)
     {
       if (verbosity == VERBOSE)
-       say ("Good.  This file appears to be the %s version.\n", revision);
+       say ("Good.  This file appears to be the %s version.\n", rev);
     }
   else if (force)
     {
       if (verbosity != SILENT)
        say ("Warning: this file doesn't appear to be the %s version -- 
patching anyway.\n",
-            revision);
+            rev);
     }
   else if (batch)
     fatal ("This file doesn't appear to be the %s version -- aborting.",
-          revision);
+          rev);
   else
     {
       ask ("This file doesn't appear to be the %s version -- patch anyway? [n] 
",
-          revision);
+          rev);
       if (*buf != 'y')
        fatal ("aborted");
     }



reply via email to

[Prev in Thread] Current Thread [Next in Thread]