[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: SIGWINCH configure check

From: Mark E.
Subject: Re: SIGWINCH configure check
Date: Mon, 13 Aug 2001 17:09:57 -0400

> On Mon, 13 Aug 2001, Mark E. wrote:
> > This patch turns off SIGWINCH support if a system doesn't support it.
> > Tested with DJGPP.
> that should be redundant (what problem are you fixing?)

This build failure:
make.exe[1]: Entering directory `d:/djgpp/gnu/ncurses-5.2/ncurses'
cd ../objects;  gcc -I../ncurses -I.  -DNDEBUG -I. -I../include -
I/dev/env/DJDIR/include -DHAVE_CONFIG_H -gstabs+  -c 
../ncurses/./tty/lib_tstp.c: In function `CatchIfDefault':
../ncurses/./tty/lib_tstp.c:267: `SIGWINCH' undeclared (first use in this 
../ncurses/./tty/lib_tstp.c:267: (Each undeclared identifier is reported 
only once
../ncurses/./tty/lib_tstp.c:267: for each function it appears in.)
../ncurses/./tty/lib_tstp.c: In function `_nc_signal_handler':
../ncurses/./tty/lib_tstp.c:347: `SIGWINCH' undeclared (first use in this 
make.exe[1]: *** [../objects/lib_tstp.o] Error 1
make.exe[1]: Leaving directory `d:/djgpp/gnu/ncurses-5.2/ncurses'
make.exe: *** [all] Error 2

The configure script automatically defines USE_SIGWINCH even if a system 
doesn't have the SIGWINCH signal. Before TIOCGWINSZ support was added to 
DJGPP, USE_SIGWINCH was automatically undefined by curses.priv.h 
(HAVE_SIZECHANGE was undefined so USE_SIGWINCH was made undefined). Now 
that TIOCGWINSZ is supported, USE_SIGWINCH is no longer turned off by 
curses.priv.h. Which then causes the build to fail in lib_tstp.c.

I notice that USE_SIGWINCH is only used in lib_tstp.c, so a suggested fix 
that avoids changing the configure script:

*** tty/lib_tstp.c.orig Mon Aug 13 09:56:16 2001
--- tty/lib_tstp.c      Mon Aug 13 10:10:18 2001
*************** MODULE_ID("$Id: lib_tstp.c,v 1.25 2001/0
*** 55,60 ****
--- 55,64 ----
  #define USE_SIGTSTP 0
+ #if !defined(SIGWINCH)
+ #endif
   * Note: This code is fragile!  Its problem is that different OSs
   * handle restart of system calls interrupted by signals differently.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]