|
From: | Paul Eggert |
Subject: | Re: [PATCH] Port to 32-bit long + 64-bit time_t |
Date: | Thu, 22 Sep 2022 11:00:52 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 |
On 9/21/22 23:49, Eli Zaretskii wrote:
This will cause problems in the native MS-Windows builds, where printf in the system C runtime doesn't support %lld and %llu.
Thanks for the review. Revised patch attached. It also addresses your comment about the commit message, plus it fixes a couple of places where I mistakenly used PRI* macros instead of SCN* macros.
Oh, one more thing, I forgot, this patch also fixes an unlikely buffer write overrun in ar_member_touch with an outlandishly-large timestamp. I mentioned that in the commit message too, and changed "<=" to "<" to make sure the updated archive header would be readable.
There are still some potential buffer read overruns in the sscanf calls in arscan.c but these could be handled by a separate patch (and are less important).
0001-Port-to-32-bit-long-64-bit-time_t.patch
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |