[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Pacify GCC -Wsign-compare
From: |
Sam James |
Subject: |
Re: [PATCH] Pacify GCC -Wsign-compare |
Date: |
Thu, 22 Sep 2022 00:11:29 +0100 |
> On 20 Sep 2022, at 22:19, Paul Eggert <eggert@cs.ucla.edu> wrote:
>
> * src/arscan.c (ar_scan): Pacify GCC 12.2.1 -Wsign-compare by copying
> an unsigned value into a signed variable before comparing it.
> Make sure it is in range before copying.
> ---
For these, could you consider including the full version? "12.2.1" identifies
only a large range of commits between 12.2 and 12.3 (it's a magic version
string used for snapshots in that range, and it'll be possibly a year before
12.3
is released).
On Gentoo for example, `gcc --version` gives:
```
gcc (Gentoo Hardened 12.2.1_p20220917 p1) 12.2.1 20220917
[...]
```
Thanks.
signature.asc
Description: Message signed with OpenPGP