[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] Handle path to shell containing space
From: |
Niklas DAHLQUIST |
Subject: |
RE: [PATCH] Handle path to shell containing space |
Date: |
Fri, 5 Jul 2019 06:58:55 +0000 |
Hi,
This is a way to reproduce the error: Copy sh to a path with space and put it
as a default shell command in makefile
i.e on Linux
copy /bin/sh to /tmp/test space/sh
create the makefiile with these lines:
SHELL=/tmp/test space/sh
all:
find *
Make will give an error like
make: /tmp/test: Command not found
/Niklas
-----Original Message-----
From: Paul Smith <address@hidden>
Sent: den 4 juli 2019 20:38
To: Niklas DAHLQUIST <address@hidden>; address@hidden
Cc: Torbjorn SVENSSON <address@hidden>
Subject: Re: [PATCH] Handle path to shell containing space
On Wed, 2019-07-03 at 08:13 +0000, Niklas DAHLQUIST wrote:
> Attached patch fixes escape of spaces in path when executing
> statements in makefiles that require shell. This ensures that the
> split between binary and arguments are valid.
It would be very helpful if you could provide an example of an
incorrectly-behaving makefile. Bonus points for turning it into an actual
regression test in the GNU make test suite, but that's not strictly necessary.
Cheers!