bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Enhance/fix VMS setting of program name, MAKE/MAKE_COMMAND,


From: h.becker
Subject: Re: [PATCH] Enhance/fix VMS setting of program name, MAKE/MAKE_COMMAND, variables
Date: Tue, 26 Aug 2014 20:56:00 +0200
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130519 Icedove/17.0.5

On 08/26/2014 11:19 AM, Ralph Corderoy wrote:
...
>                 progname = malloc(strlen(p) + 1);
> 
> Can malloc fail on VMS?
...
>                 if (0 == strcasecmp(&progname[len - 4], ".exe"))
> 
> What if len is less than 4?

Parsing the file specification myself wasn't a good idea. I should have
known better. I'll change the code and let VMS do the parsing. This code
is in a VMS specific source anyway. And I'll use xmalloc() as pointed
out by Paul.

Thanks for reviewing the code,
Hartmut




reply via email to

[Prev in Thread] Current Thread [Next in Thread]