Re: Add "makefile.mak" to list of default makefiles

[Jonny Grant]

On 7 July 2014 07:06, Paul Smith <address@hidden> wrote:
> On Mon, 2014-06-30 at 21:28 +0100, Jonny Grant wrote:
>> I have a few, but triggered by make -f makefile.mak. So it would be
>> quite useful GNU Make could pick up the Windows makefile extension
>> .MAK
>
> If Eli feels this is useful for Windows implementations he can add it;
> however, I don't want this added for the non-Windows ports. I've never
> seen anyone name a makefile like this on any UNIX/POSIX system, ever.
>
> As Reinier points out, on UNIX/POSIX systems you often see ".mk" used as
> an extension, but never (IME) "Makefile.mk"; UNIX/POSIX environments
> don't rely (solely) on extensions and (again IME) have no problem
> understanding that files named "Makefile" or "makefile" are makefiles,
> even without extensions.
>
> Renaming the Windows README files is also fine with me if it's fine with Eli.

Hi Paul, Eli

Okay, so I propose this patch:

--- read.c 2013-10-09 06:22:42.000000000 +0100
+++ read.c.new 2014-07-07 18:10:43.914952000 +0100
@@ -246,7 +246,11 @@
#ifdef _AMIGA
{ "GNUmakefile", "Makefile", "SMakefile", 0 };
#else /* !Amiga && !VMS */
+#ifdef WINDOWS32
+ { "GNUmakefile", "makefile", "Makefile", "makefile.mak", 0 };
+#else
{ "GNUmakefile", "makefile", "Makefile", 0 };
+#endif
#endif /* AMIGA */
#endif /* VMS */
register char **p = default_makefiles;

Also renaming README.W32 -> README_W32.txt

Best regards, Jon