Re: [bug-mailutils] Where is the patch to fix shell.c or dependency

[Sergey Poznyakoff]

Hi Darel,

>   rl_attempted_completion_function = (CPPFunction *) shell_completion;

Apparently this typedef was gone since readline 4.2.  Please try the
attached patch.

Regards,
Sergey

diff --git a/examples/nntpclient.c b/examples/nntpclient.c
index 1d822f6..2fd3a0d 100644
--- a/examples/nntpclient.c
+++ b/examples/nntpclient.c
@@ -163,7 +163,7 @@ initialize_readline ()
   rl_readline_name = (char *) "nntp";

   /* Tell the completer that we want a crack first. */
-  rl_attempted_completion_function = (CPPFunction *) nntp_completion;
+  rl_attempted_completion_function = nntp_completion;
 }

 /* Attempt to complete on the contents of TEXT.  START and END bound the
diff --git a/libmailutils/mailbox/biffnotify.c 
b/libmailutils/mailbox/biffnotify.c
index 2a3bdd7..2169e07 100644
--- a/libmailutils/mailbox/biffnotify.c
+++ b/libmailutils/mailbox/biffnotify.c
@@ -20,6 +20,8 @@
 #endif

 #include <unistd.h>
+#include <sys/types.h>
+#include <sys/socket.h>
 #include <stdlib.h>
 #include <string.h>
 #include <netinet/in.h>
diff --git a/mail/mailline.c b/mail/mailline.c
index 5060a26..5560c56 100644
--- a/mail/mailline.c
+++ b/mail/mailline.c
@@ -93,7 +93,7 @@ ml_readline_init ()

 #ifdef WITH_READLINE
   rl_readline_name = "mail";
-  rl_attempted_completion_function = (CPPFunction*)ml_command_completion;
+  rl_attempted_completion_function = ml_command_completion;
   rl_getc_function = ml_getc;
 #endif
 #ifdef HAVE_SIGACTION
diff --git a/mu/shell.c b/mu/shell.c
index 54fb22c..46fb269 100644
--- a/mu/shell.c
+++ b/mu/shell.c
@@ -336,7 +336,7 @@ mutool_initialize_readline (const char *name)
 {
   /* Allow conditional parsing of the ~/.inputrc file. */
   rl_readline_name = (char *) name;
-  rl_attempted_completion_function = (CPPFunction *) shell_completion;
+  rl_attempted_completion_function = shell_completion;
   rl_getc_function = _shell_getc;
   read_history (get_history_file_name ());
 }