Re: [bug-mailutils] crash on invalid config file

[Sergey Poznyakoff]

Hi Simon,

> Hi, I noticed this crash when using an invalid configuration file:
> 
> address@hidden:~/src/mailutils/imap4d master$ cat 
> /home/jas/src/www-gsasl/test-server/imap4d.rc server {
>   transcript true;
> }

Thanks! Here's the fix:

diff --git a/mailbox/msrv.c b/mailbox/msrv.c
index a318371..13a85d4 100644
--- a/mailbox/msrv.c
+++ b/mailbox/msrv.c
@@ -970,7 +970,7 @@ server_section_parser (enum mu_cfg_section_stage stage,
     {
     case mu_cfg_section_start:
       {
-       if (node->label->type != MU_CFG_STRING)
+       if (node->label == NULL || node->label->type != MU_CFG_STRING)
          return 1;
        /* FIXME: should not modify 2nd arg, or it should not be const */
        return server_block_begin (tree->debug, node->label->v.string,

Regards,
Sergey