Re: [bug-mailutils] imap[s] seg fault in mail[x]

[Paul Vojta]

Sergey:

Yes, the patch works.

However, on further thought, it seems that all occurrences of sp in that
long if statement should really be sp1 -- otherwise they refer to text
after the ']', which doesn't make sense (keep in mind that my knowledge
of the IMAP protocol is next to nil).

Also, I'm a bit uncomfortable with the direct use of the value of sp/sp1.
The value is not documented (at least not in the man page), and in
principle an implementation could store the end of the previous string
there instead of the first character after it.

So, I'd prefer to see the attached patch used instead.

--Paul


On Wed, Feb 18, 2009 at 12:30:55PM +0200, Sergey Poznyakoff wrote:
> Hi Paul,
> 
> > However, it seems to be a bug that the third argument to strtok_r()
> > in lines 2431, 2439, and 2446 of libproto/imap/folder.c is &sp instead
> > of &sp1.
> 
> Yes, it definitely is. Please try the attached patch. Does it work for
> you?
> 
> Regards,
> Sergey

diffs
Description: Text document