RE: [bug-mailutils] Snapshot 20050906 broke everything!

[Alain Magloire]

> -----Original Message-----
> From: address@hidden [mailto:bug-mailutils-
> address@hidden On Behalf Of Sergey Poznyakoff
> Sent: Tuesday, September 20, 2005 3:00 PM
> To: address@hidden
> Subject: Re: [bug-mailutils] Snapshot 20050906 broke everything!
> 
....

> 
> > My questions:
> > - are these changes enough or your redesign goes deeper?
> 
> All the principal changes are already done. The only major change
> waiting in my todo is getting rid of the last argument ('owner') in
> <object>_destroy calls.
> 

Are you thinking of the reference counting?
That also means that we must be more careful and every call to a
<object>_create or <object>_get_<object> must call <object>_destroy

{
        message_t mesg;
        mu_mailbox_get_message(mbox, 1, &mesg);
        ....
        // unref the message we do not need it anymore
        mu_message_destroy(mesg);
}

Also would advocate for symmetry we have
mu_<object>_ref()
mu_<object>_unref()  
for example:
mu_message_ref();
mu_message_unref();

Anyway, I was not sure if these were the changes you have in mind.