Re: [bug-mailutils] maildir patch (based on 0.4)

[Stephen Bylo]

Hi Sergey,

I have been testing the patch and find that it does not provide any kind
of mail uid ( like mbox does through message_get_uid() ).  Is this not
needed in all mailbox implementations and not just mbox?

There are a couple of other issues that will be corrected in the next
mailddir patch release.

Meanwhile, have you managed to further test the maildir patch yourself?

Thanx
Steve

On Tue, 2003-11-04 at 06:49, Sergey Poznyakoff wrote:
> Hi,
> 
> Thanks again for your patch. I've finally managed to test reading and
> adding to the mailbox. Good job. The patch seems to work OK, though
> there are several notes:
> 
> 1) The return value from opendir() is always used without checking,
> which leads to coredump if one of the subdirs "cur", "tmp" or "new"
> does not exist. A check for (errno==ENOENT) should follow, and if
> it succeeds, mkdir should be called.
> 
> 2) The function _mh_delim() is entirely MH-specific and irrelevant to
> maildir. For maildir, the usual test str[0]=='\n' will suffice.
> 
> 3) In _maildir_message_save a part of code saving X-IMAP-Base
> header is commented out with a notice   /* no IMAP needed in maildir*/,
> which I don't quite understand. X-IMAP-Base may be needed no matter
> what the mailbox format is.
> 
> Apart from that, everyhting is OK. I haven't tested the locking
> and NFS interaction issues, though.
> 
> A side note: generally speaking, I'd like it to be better integrated to
> the overall structure. I thought it was going to be very similar to MH,
> and yet it has overcome my expectations: so much MH code is duplicated
> in  maildir that I'm going to move their "common denominator" to
> mailbox, which will probably reduce both libmh and libmaildir sources
> to some 100-200 lines of code.
> 
> I'll write more on it when I'm through doing tests.
> 
> Thank you,
> Sergey
> 
> 
> 
> 
> _______________________________________________
> Bug-mailutils mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/bug-mailutils
--