bug-mailutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Fwd: Re: [bug-mailutils] maildir patch (based on 0.4)]


From: Tang Yong Ping
Subject: [Fwd: Re: [bug-mailutils] maildir patch (based on 0.4)]
Date: 11 Nov 2003 11:36:17 +0800

--- Begin Message --- Subject: Re: [bug-mailutils] maildir patch (based on 0.4) Date: 11 Nov 2003 10:07:00 +0800
hi Sergey,
  Thank you for your test.
  The following is some updates.

> Hi,
> 
> Thanks again for your patch. I've finally managed to test reading and
> adding to the mailbox. Good job. The patch seems to work OK, though
> there are several notes:
> 
> 1) The return value from opendir() is always used without checking,
> which leads to coredump if one of the subdirs "cur", "tmp" or "new"
> does not exist. A check for (errno==ENOENT) should follow, and if
> it succeeds, mkdir should be called.

 
> 2) The function _mh_delim() is entirely MH-specific and irrelevant to
> maildir. For maildir, the usual test str[0]=='\n' will suffice.

I've modified these two parts.
 
> 3) In _maildir_message_save a part of code saving X-IMAP-Base
> header is commented out with a notice   /* no IMAP needed in maildir*/,
> which I don't quite understand. X-IMAP-Base may be needed no matter
> what the mailbox format is.

I'm thinking about it. one question, how to generate a sequence number
based on unique name?
 
> Apart from that, everyhting is OK. I haven't tested the locking
> and NFS interaction issues, though.
> 
> A side note: generally speaking, I'd like it to be better integrated to
> the overall structure. I thought it was going to be very similar to MH,
> and yet it has overcome my expectations: so much MH code is duplicated
> in  maildir that I'm going to move their "common denominator" to
> mailbox, which will probably reduce both libmh and libmaildir sources
> to some 100-200 lines of code.
> 
> I'll write more on it when I'm through doing tests.

if there's any update on this area, would you please let me know?
thanks.

> Thank you,
> Sergey
> 
> 

best regards,
-- 
Tang Yong Ping
Software Developer

RADIXS Private Limited
EMAIL:    address@hidden 
<mailto:address@hidden>
MOBILE:    +65 9433 4718
DID:       +65 6831 0636

TEL:       +65 6831 0600
FAX:       +65 6831 0601
WEB:       www.radixs.com <http://www.radixs.com/>

Address: 391A Orchard Road, #24-04 Tower A, Ngee Ann City, Singapore
238873

Disclaimer Notice: 

This email, its content and any files transmitted with it are intended
solely for the addressee(s) and may be confidential and privileged.  Any
unauthorised disclosure or use or dissemination of the information
contained herein, either whole or partial, is prohibited.  RADIXS
Private Limited (RADIXS) cannot accept liability for any statements made
which are clearly the sender's own and not expressly made on behalf of
RADIXS or one of its agents. If you have received this message in error,
please notify the sender immediately, and delete this email from your
computer system. RADIXS has taken reasonable precaution to ensure no
viruses are present in this email, however RADIXS does not accept
responsibility for any loss or damage arising from the use of this email
or attachments.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]