Re: [bug-mailutils] [PATCH] SASL fix

[Simon Josefsson]

Sergey Poznyakoff <address@hidden> writes:

> Hi Simon,

Hello.

>> Some SASL mechanisms output data when GSASL_OK is returned (data which
>> doesn't affect the outcome of the SASL negotiation, typically data
>> that provides mutual authentication for the client).  This makes sure
>> it is sent.
> [...]
>> +  if (output_len > 0)
>> +    util_send ("+ %s\r\n", output);
>> +
>
> Output_len will always be greater then zero, so util_send will be
> called unconditionally. Or did you mean
>
>   if (output[0])
>     util_send ("+ %s\r\n", output);
>
> ?

Yes.  Sorry, I confused the interface with how mechanisms internally
in libgsasl work -- they set the output_len variable too.

The step and encode/decode interfaces will probably be changed in the
future to return newly allocated strings instead -- looping around the
function when it returns GSASL_TOO_SMALL_BUFFER generates ugly code
both in the application and in libgsasl.  (But don't worry: the old
API will continue to work for a long time, so no need to redo any of
your work.)