Re: pop3d and imap4d's locking behaviour

[Sam Roberts]

Quoting Alain Magloire <address@hidden>, who wrote:
> > 
> > Ok, 1 bug in mbx_mboxscan.c (wasn't checking return value
> > of locker_lock()) fixed.
> 
> hum .. hum .. this was actually my doing.  I remember now
> when testing the mailbox stuff, I was getting tired to always
> "su -" and chmod to sgid on every recompile ... and forgot
> about it.

:-) It happens!

I'm thinking about adding a MU_LOCKER_NO_LOCK mode, which will
silently NOT lock the mailbox, so you can get that mode if you
want. This would allow utilities that are opening mailboxes read
only and just want to be fast (like "messages") to set this
as a flag.

Also, I want to add a MU_LOCKER_EXTERNAL flag (and a
locker_set_external(debug_t d, const char* program)) to call
dotlock (or mutt_dotlock, if you'd rather). I think this would
address the setgid irritation.

As soon as I can...

Sam
p.s. Spring is coming fast, a good thing.

> 
> > IMAP's SELECT doesn't check mailbox return values either,
> > this seems to work (in that select now fails if the mailbox
> > can't be locked), but it modifies global state so I don't
> > want to apply it, and there are other callers of this
> > function that should likely check its status.
> 
> I do not remember the code so can not comment intelligently
> about that piece.
> 
> > But its late and I have to go to bed.
> > 
> 
> Later.
> 
> 
> _______________________________________________
> Bug-mailutils mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/bug-mailutils

-- 
Sam Roberts <address@hidden> (Vivez sans temps mort!)