bug-mailutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Mailutils configuration, some work needed


From: Sam Roberts
Subject: Re: Mailutils configuration, some work needed
Date: Thu, 28 Feb 2002 09:19:03 -0500
User-agent: Mutt/1.3.16i

Bonjour,

I like the % notation.

I have to do a little more testing of my dotlock changes, make sure
that mutt and pop3d and imap4d all agree on who owns the lock, then
commit them, and I'll be away for the next two weekends, so
I might not get to working on the config stuff until then.

One other thing I've been thinking about. What do you think about
using the debug_t object to repor errors?

I added the error level to the debug print callback, so now we
should be able to have a generic debug syslog callback that looks like:

int mu_debug_syslog(mu_debug_t d, size_t level, const char* fmt, va_list va)
{
  int loglevel = LOG_DEBUG;
  switch(level)
  {
    case MU_DEBUG_ERROR: loglevel = LOG_ERR; break;
    case MU_DEBUG_TRACE: loglevel = LOG_INFO; break;
  }

  vsyslog(loglevel, fmt, va);
}

It seems to me that the mu_error() mechanism is a duplication. The
one thing it does, is that it can be called without having a debug
object, but that just makes me think everything should have a debug
object!

What do you all think? I guess the syslog facility standard argument
would do an openlog() to set the facility, and perhaps it should
set the log mask to ALL so that the debug_t.level is what decides
what gets logged.

If this idea is OK, I can start migrating mu_error() calls over
slowly until it can be removed completely.

Cheers.

Sam


Quoting Sergey Poznyakoff <address@hidden>, who wrote:
> On Sun, 24 Feb 2002 11:42:36 +0200, Sergey Poznyakoff wrote:
> > I'll commit mailbox_open_default changes later in the day.
> 
> It took a bit longer to check that everything works. I've
> committed the changes. mailbox_open_default() now behaves
> almost as you have described except the following:
> 
>      %           --> system mailbox, corresponding to the real uid
>      %user       --> system mailbox for the given user
> 
> To avoid possible nameclashes I've renamed maildir to mu_path_maildir.
> It is now declared in mailbox/mbx_default.c. The extern declaration is
> in include/mailutils/mailbox.h.
> 
> Regards,
> Sergey
> 
> _______________________________________________
> Bug-mailutils mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/bug-mailutils

-- 
Sam Roberts <address@hidden> (Vivez sans temps mort!)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]