address@hidden: Bug#126755: mailutils-doc: Missing function prototypes]

[Jeff Bailey]

I don't understand what guimb does, so I'm not sure how to validate
this patch.

----- Forwarded message from "John R.Daily" <address@hidden> -----

Subject: Bug#126755: mailutils-doc: Missing function prototypes
From: "John R.Daily" <address@hidden>

Package: mailutils-doc
Version: N/A; reported 2001-12-28
Severity: normal
Tags: patch

On the ia64 platform, functions that return 64-bit values
but are not prototyped can cause data corruption and
segfaults, because the compiler assumes undeclared functions
return 32-bit integers.

This patch addresses all the 64-bit missing prototype issues
I found.

Note that completion_matches is deprecated and no longer
prototyped in readline.h (except in an #if 0 block). The
addition of 'const' to the ml_command_generator()
argument was to comply with the prototype of
rl_completion_matches.

diff -aur mailutils.orig/mailutils-20011103/guimb/guimb.h 
mailutils-20011103/mailutils-20011103/guimb/guimb.h
--- mailutils.orig/mailutils-20011103/guimb/guimb.h     Sat Aug  4 09:35:01 2001
+++ mailutils-20011103/mailutils-20011103/guimb/guimb.h Fri Dec 28 10:51:51 2001
@@ -22,6 +22,7 @@
 #include <stdio.h>
 #include <unistd.h>
 #include <errno.h>
+#include <string.h>  /* strerror(3), strdup(3) */
 
 #include <mailutils/mailbox.h>
 #include <mailutils/message.h>
diff -aur mailutils.orig/mailutils-20011103/mail/mailline.c 
mailutils-20011103/mailutils-20011103/mail/mailline.c
--- mailutils.orig/mailutils-20011103/mail/mailline.c   Sat Nov  3 10:36:26 2001
+++ mailutils-20011103/mailutils-20011103/mail/mailline.c       Fri Dec 28 
11:11:45 2001
@@ -18,7 +18,7 @@
 #include "mail.h"
 
 static char **ml_command_completion __P((char *cmd, int start, int end));
-static char *ml_command_generator __P((char *text, int state));
+static char *ml_command_generator __P((const char *text, int state));
 
 static volatile int _interrupted;
 
@@ -218,7 +218,7 @@
 {
   (void)end;
   if (start == 0)
-    return completion_matches (cmd, ml_command_generator);
+    return rl_completion_matches (cmd, ml_command_generator);
   return NULL;
 }
 
@@ -226,7 +226,7 @@
  * more readline
  */
 char *
-ml_command_generator (char *text, int state)
+ml_command_generator (const char *text, int state)
 {
   static int i, len;
   const char *name;

-- System Information
Debian Release: 3.0
Architecture: ia64
Kernel: Linux butthead.progeny.com 2.4.9-itanium-smp #1 SMP Mon Sep 17 20:48:35 
MDT 2001 ia64
Locale: LANG=en_US, LC_CTYPE=en_US


----- End forwarded message -----

-- 
I gotta ding ding dang a dang a long ding dong.