Re: Inconsistency in attribute.c

[Alain Magloire]

> Bonjour,

8-)

> 
> Every attribute_set_.* function sets MU_ATTRIBUTE_MODIFIED bit in
> attr->flags, but does not do the same when calling attr->_set_flags().
> >From the other hand, every attribute_is_.* function calls
> attr->_get_flags (attr, &(attr->flags)) and thus clears
> MU_ATTRIBUTE_MODIFIED bit.
> 
> If we do attribute_set_deleted() and attribute_is_deleted(),
> a subsequent call to mbox_expunge() will not remove the message
> since the function relies on MU_ATTRIBUTE_MODIFIED being set
> on deleted messages.
> 
> Should we make every attribute_set_.* set MU_ATTRIBUTE_MODIFIED in
> _set_flags call as well, or am I missing something?

hmmm, at first glance, I do not think you are.
Feel free to update.

I will be checking a litlle closer Sunday.
I still did not do the mailbox_save_flags() stuff.

--
alain