bug in mbx_mboxscan.c

[Sergey Poznyakoff]

Hi,

I have just tracked down two bugs. One is a simple typo in pop3d/pop3d.c,
another one is quite an interesting one :^)

ChangeLog:
        * Typo in pop3d/pop3d.c
        * Bug in mailbox/mbx_mboxscan.c made the stuff coredump upon
          encountering more than one subject in the header.

Patch:

Index: mailbox/mbx_mboxscan.c
===================================================================
RCS file: /cvs/mailutils/mailbox/mbx_mboxscan.c,v
retrieving revision 1.11
diff -p -u -r1.11 mbx_mboxscan.c
--- mailbox/mbx_mboxscan.c      2001/04/12 15:34:08     1.11
+++ mailbox/mbx_mboxscan.c      2001/05/19 11:49:40
@@ -711,8 +711,6 @@ mbox_scan0 (mailbox_t mailbox, size_t ms
            }
          else if (ISSUBJECT(buf))
            {
-             char *ss = NULL;
-             if (mum->fhdr[H_SUBJECT]) *ss = 1;
              FAST_H_SUBJECT (mum, sfield, buf, n);
            }
          else if (ISTO(buf))
--- orig/pop3d.c        Sun May 20 11:14:38 2001
+++ pop3d.c     Sun May 20 11:14:51 2001
@@ -233,7 +233,7 @@ pop3d_mainloop (int infile, int outfile)
 
   ifile = fdopen (infile, "r");
   ofile = fdopen (outfile, "w");
-  if (!ofile || !ofile)
+  if (!ifile || !ofile)
     pop3d_abquit (ERR_NO_OFILE);
 
   state = AUTHORIZATION;


Cheers,
Sergey