Re: Invalid SVG generation for filenames that have quotes embedded.

[Richard Shann]

On Thu, 2016-02-11 at 18:34 +0100, Simon Albrecht wrote:
> Hello Richard,
> 
> On 11.02.2016 15:51, Richard Shann wrote:
> > It should escape them thus:
> 
> I think you might just come up with a patch for review. In case you’re 
> not familiar with the proceedings: it’s not that complicated. Most of it 
> is explained in the CG; for a basic ‘how-to’ see 
> <http://lists.gnu.org/archive/html/lilypond-user/2016-02/msg00172.html>.
> If you don’t want to do that, I could do it for you.

Thanks for this - I've been busy getting out the Denemo release, hence
the delay. 
I managed to characterise this problem better - it is actually the
\markup \with-url construct that is causing the problem. If the URL
includes quotes, then the generated SVG is invalid XML syntax. The
filename case is probably true but is too esoteric to be interesting.

Attached is a patch for output-svg.scm taken from today's git (the last
commit affecting this file is a couple of weeks ago:
f30a8189adbbeefa2103e2c2e194040f66bc2291).

I've been able to test it but, unfortunately only from a fairly
complicated bit of code (it's an adaptation of Mathieu Demange's new
code for his Live Score). I don't understand what, in that code, it is
that is actually triggering the placing of url's in an SVG. They are
normally ignored. And I don't know if there is any test in the LilyPond
test suite for this - in fact, I really don't know if there are any
programs out there that make use of such information when they import an
SVG file (that is, I'm not sure why it is ever being generated in the
first place).

I hope this will be useful,

Richard

OutputSVG.patch
Description: Text Data