Re: Chord tremolo broken in 1.5.43

[Mats Bengtsson]

A follow-up on this bug. It seems that this problem is 
caused by the change in stem-engraver.cc that was 
introduced in 1.5.22 together with the Completion_heads_engraver.
What happens is that the Chord_tremolo_engraver changes
the duration-log of the note heads to get the correct
unfilled note heads for chord tremolos lasting longer than
a quarter note. The current stem engraver uses this
setting to determine the number of flags.

I have not seen anyone using the Completion_heads_engraver,
neither among the example files nor mentioned on the mailing
list. Chord tremolos, on the other hand, are very common.
Therefore, I suggest that we revert the stem-engraver.cc
patch from 1.5.22 until we find a new solution that can handle
both features.

I've attached a patch, which also includes a couple of less
controversial changes.

   /Mats


> Only a single beam is printed for chord tremolo no
> matter what duration you specify, see
> input/regression/chord-tremolo.ly.
> 
>    /Mats

Generated by (address unknown),
>From = lilypond-1.5.50, To = lilypond-1.5.50.mb1

usage 

    cd lilypond-source-dir; patch -E -p1 < lilypond-1.5.50.mb1.diff

Patches do not contain automatically generated files 
or (urg) empty directories, 
i.e., you should rerun autoconf, configure

diff -purN ../lilypond-1.5.50/ChangeLog ./ChangeLog
--- ../lilypond-1.5.50/ChangeLog        Tue Apr  2 00:56:31 2002
+++ ./ChangeLog Sat Apr  6 13:57:40 2002
@@ -1,3 +1,11 @@
+2002-04-06  Mats Bengtsson  <address@hidden@s3.kth.se>
+
+       * lily/stem-engraver.cc (acknowledge_grob): Revert to old way of
+       finding out the duration. Fixes chord tremolo bug. Breaks
+       Completion_heads_engraver, though.
+
+       * lilypond-mode.el: Added "2Midi" command
+
 2002-04-02  Han-Wen  <address@hidden>
 
        * VERSION: release 1.5.50
diff -purN ../lilypond-1.5.50/Documentation/topdocs/INSTALL.texi 
./Documentation/topdocs/INSTALL.texi
--- ../lilypond-1.5.50/Documentation/topdocs/INSTALL.texi       Sat Mar 23 
00:17:51 2002
+++ ./Documentation/topdocs/INSTALL.texi        Sat Apr  6 00:29:00 2002
@@ -126,7 +126,6 @@ Check out @uref{http://www.python.org, t
 @item GUILE (version 1.4 or newer).
 Check out
 @uref{http://www.gnu.org/software/guile/guile.html,the GUILE webpage}.
-Version 1.4 is recommended for better performance.
 
 @item GNU Make. 
 Check out
diff -purN ../lilypond-1.5.50/VERSION ./VERSION
--- ../lilypond-1.5.50/VERSION  Tue Apr  2 00:55:44 2002
+++ ./VERSION   Sat Apr  6 00:27:00 2002
@@ -2,7 +2,7 @@ PACKAGE_NAME=LilyPond
 MAJOR_VERSION=1
 MINOR_VERSION=5
 PATCH_LEVEL=50
-MY_PATCH_LEVEL=
+MY_PATCH_LEVEL=mb1
 
 
 # use the above to send patches: MY_PATCH_LEVEL is always empty for a
diff -purN ../lilypond-1.5.50/lily/stem-engraver.cc ./lily/stem-engraver.cc
--- ../lilypond-1.5.50/lily/stem-engraver.cc    Tue Apr  2 00:48:01 2002
+++ ./lily/stem-engraver.cc     Sat Apr  6 14:00:08 2002
@@ -54,11 +54,23 @@ Stem_engraver::acknowledge_grob (Grob_in
       if (Rhythmic_head::stem_l (h))
        return;
 
+      /* Reverted to the old method so chord tremolos work again.
+        Breaks Completion_heads_engraver though.  /MB 
+      */
+      Duration *d = unsmob_duration (h->get_grob_property ("duration"));
+      int duration_log = 0;
+      if (d)
+       {
+         duration_log = d-> duration_log ();
+       }
+
+#if 0
       /*
        We take the duration-log of the head; this is because
        auto-tieing does strange things with the rhythmics.
        */
       int duration_log  =gh_scm2int (h->get_grob_property ("duration-log"));
+#endif
       if (!stem_p_) 
        {
          stem_p_ = new Item (get_property ("Stem"));
diff -purN ../lilypond-1.5.50/lilypond-mode.el ./lilypond-mode.el
--- ../lilypond-1.5.50/lilypond-mode.el Sun Mar 17 19:22:19 2002
+++ ./lilypond-mode.el  Sat Apr  6 00:26:04 2002
@@ -169,6 +169,7 @@ in LilyPond-include-path."
 
     ("2Dvi" . ("ly2dvi %s" . "View"))
     ("2PS" . ("ly2dvi -P %s" . "View"))
+    ("2Midi" . ("lilypond -m %s" . "View"))
 
     ("Book" . ("lilypond-book %x" . "LaTeX"))
     ("LaTeX" . ("latex '\\nonstopmode\\input %l'" . "View"))